Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(24)

Issue 309780043: Issue 4931 make deadNote work with other font-settings (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by thomasmorley651
Modified:
7 years, 2 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Issue 4931 make deadNote work with other font-settings This is done by temporarily setting font-name to '(), causing the default-font (usually Feta) to take over, reverting this later. The regtest dead-notes.ly is altered accordingly. Also, ly-syntax is used where possible. palmMute and harmonic are not affected by this patch and still work nicely.

Patch Set 1 #

Patch Set 2 : regtest-version corrected #

Patch Set 3 : adressing Davids comment #

Patch Set 4 : rebase, clean-up, comment extended #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -32 lines) Patch
M input/regression/dead-notes.ly View 1 2 3 2 chunks +44 lines, -19 lines 0 comments Download
M ly/property-init.ly View 1 2 3 2 chunks +31 lines, -13 lines 0 comments Download

Messages

Total messages: 8
thomasmorley651
7 years, 8 months ago (2016-07-27 12:30:43 UTC) #1
thomasmorley651
regtest-version corrected
7 years, 8 months ago (2016-07-27 13:32:04 UTC) #2
dak
On 2016/07/27 13:32:04, thomasmorley651 wrote: > regtest-version corrected If we have the meanings to spit ...
7 years, 8 months ago (2016-07-27 14:12:12 UTC) #3
thomasmorley651
On 2016/07/27 14:12:12, dak wrote: > On 2016/07/27 13:32:04, thomasmorley651 wrote: > > regtest-version corrected ...
7 years, 8 months ago (2016-07-27 14:28:36 UTC) #4
thomasmorley651
adressing Davids comment
7 years, 8 months ago (2016-07-27 17:13:58 UTC) #5
thomasmorley651
On 2016/07/27 14:12:12, dak wrote: > On 2016/07/27 13:32:04, thomasmorley651 wrote: > > regtest-version corrected ...
7 years, 8 months ago (2016-07-27 17:16:25 UTC) #6
thomasmorley651
On 2016/07/27 17:16:25, thomasmorley651 wrote: > Bad I have no other music-font to test installed ...
7 years, 8 months ago (2016-07-27 21:24:32 UTC) #7
thomasmorley651
7 years, 2 months ago (2017-01-08 09:51:26 UTC) #8
rebase, clean-up, comment extended
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b