Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(12615)

Issue 309720043: #4938 Refactor handling of supported MIDI control changes (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by ht
Modified:
7 years, 8 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add Audio_item and Midi_item subclasses for (MIDI control, value) changes Refactor handling of MIDI control changes Handle the MIDI control value initialization from context properties (Staff_performer::new_audio_staff), control value changes (Midi_control_function_performer::announce_function_value_change), and value conversion for output (Midi_control_function_value_change::to_string) in the new Midi_control_change_announcer class. All MIDI control changes are now encoded using {Audio,Midi}_control_change items. This change makes the old {Audio,Midi}_control_function_value_change classes obsolete. Rename Midi_control_function_performer to Midi_control_change_performer

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -286 lines) Patch
M lily/audio-item.cc View 1 chunk +5 lines, -17 lines 0 comments Download
M lily/include/audio-item.hh View 1 chunk +4 lines, -27 lines 0 comments Download
M lily/include/lily-proto.hh View 2 chunks +3 lines, -2 lines 0 comments Download
A lily/include/midi-cc-announcer.hh View 1 chunk +64 lines, -0 lines 0 comments Download
M lily/include/midi-item.hh View 1 chunk +13 lines, -13 lines 0 comments Download
A lily/midi-cc-announcer.cc View 1 chunk +110 lines, -0 lines 0 comments Download
A lily/midi-cc-performer.cc View 1 chunk +150 lines, -0 lines 0 comments Download
D lily/midi-control-function-performer.cc View 1 chunk +0 lines, -138 lines 0 comments Download
M lily/midi-item.cc View 4 chunks +10 lines, -62 lines 0 comments Download
M lily/staff-performer.cc View 4 chunks +41 lines, -26 lines 0 comments Download
M ly/performer-init.ly View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 1
ht
7 years, 9 months ago (2016-07-20 19:24:28 UTC) #1
This patch set separates the code refactoring originally done for Issue 4745
from the enhancements implemented as part of that issue. The patch does not
change any existing functionality (nor introduce any new features), its purpose
is to only improve the maintainability of the current implementation by
simplifying the interfaces, removing duplication of code, and cleaning up some
terminology.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b