Looks a lot better. I've indicated one detail. Also the use of the spacing suffix ...
14 years, 5 months ago
(2010-11-14 09:13:35 UTC)
#2
Looks a lot better. I've indicated one detail. Also the use of the spacing
suffix on property names looks inconsistent to me. I've not marked these as
there may be more outside this patch, but it seems to be omitted or included
fairly randomly. Could you check this out?
Trevor
http://codereview.appspot.com/3089042/diff/1/Documentation/notation/spacing.i...
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/3089042/diff/1/Documentation/notation/spacing.i...
Documentation/notation/spacing.itely:1672: unset, for ungrouped staves and for
grouped staves that do not
Still difficult to parse. How about two sentences: "... when it is unset.
Applies to ungrouped staves ..."
Trevor Daniels wrote: > Looks a lot better. I've indicated one detail. Also the > ...
14 years, 5 months ago
(2010-11-14 09:47:40 UTC)
#3
Trevor Daniels wrote:
> Looks a lot better. I've indicated one detail. Also the
> use of the spacing suffix on property names looks
> inconsistent to me. I've not marked these as there may be
> more outside this patch, but it seems to be omitted or
> included fairly randomly. Could you check this out?
I don't follow -- "the use of the spacing suffix on property
names..." Could you explain what you mean by that?
Thanks.
- Mark
Trevor Daniels wrote: > Looks a lot better. I've indicated one detail. Also the > ...
14 years, 5 months ago
(2010-11-14 09:47:40 UTC)
#4
Trevor Daniels wrote:
> Looks a lot better. I've indicated one detail. Also the
> use of the spacing suffix on property names looks
> inconsistent to me. I've not marked these as there may be
> more outside this patch, but it seems to be omitted or
> included fairly randomly. Could you check this out?
I don't follow -- "the use of the spacing suffix on property
names..." Could you explain what you mean by that?
Thanks.
- Mark
On 2010/11/14 09:47:40, markpolesky_yahoo.com wrote: > I don't follow -- "the use of the spacing ...
14 years, 5 months ago
(2010-11-14 12:50:00 UTC)
#5
On 2010/11/14 09:47:40, markpolesky_yahoo.com wrote:
> I don't follow -- "the use of the spacing suffix on property
> names..." Could you explain what you mean by that?
My mistake! I think I must have misread staff-affinity. (I should have learned
by now not to try to review things in 5 minutes before I have to rush out!)
Sorry!
Trevor
Issue 3089042: Doc: NR 4.4.1: Clean up property descriptions.
(Closed)
Created 14 years, 5 months ago by Mark Polesky
Modified 14 years, 5 months ago
Reviewers: Trevor Daniels, markpolesky_yahoo.com, carl.d.sorensen_gmail.com
Base URL:
Comments: 2