Issue 30890043: Make make-relative able to deal with music rather than just pitches (Closed)
DescriptionMake make-relative able to deal with music rather than just pitches
I'm leaning towards letting this slip into 2.18 still. The reason is
that make-relative in its current form is only useful for a quite
limited number of cases, can't be easily coded as a subcase of the new
behavior, and the convert-ly rule only covers the most important use
cases.
Due to its limited usefulness, it has not seen much exposure on the
mailing lists and is likely not in use much, so retaining the function
name and obliterating the old, less useful behavior, makes sense
before 2.18. Afterwards, this would be harder.
Consists of commits (reverse order):
Add regtest for music argument semantics of make-relative macro
Run convert-ly on input/regression/make-relative.ly
convert-ly rule for new make-relative semantics accepting music arguments
This only works when the "reference pitch" is the first or last of
the list.
Make make-relative able to deal with music rather than just pitches
The old behavior of make-relative was too cumbersome to use in many
cases.
This variant allows, for example:
withOctave =
(ly:music?)
(make-relative
(music) music
#{ \context Bottom << $music \transpose c c' $music >> #}))
\relative
\new Staff \withOctave {
\partial 4. c'8 e g |
c2 e,4 g |
c,8 c' b a <g d'> <f c'> <e b'> <d a'> |
<c g'>1 | \bar "|."
}
Patch Set 1 #
Total comments: 1
Patch Set 2 : Fix texidoc comment #Patch Set 3 : Fix an obscure copying bug, explain user-visible part, provide regtest #
MessagesTotal messages: 4
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||
