Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(346)

Issue 307041: adding new spline() function signature (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
14 years, 1 month ago by clifford.stein
Modified:
13 years, 3 months ago
Reviewers:
dev-osl, larrygritz, osl-dev, ckulla
Base URL:
http://openshadinglanguage.googlecode.com/svn/trunk/
Visibility:
Public.

Description

Adds new form of spline in which the user can specify the number of knots to use in a supplied array. For example: spline(basis, x, num_knots, knots)

Patch Set 1 #

Patch Set 2 : removing knot-count limit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -15 lines) Patch
src/liboslcomp/typecheck.cpp View 1 chunk +1 line, -1 line 0 comments Download
src/liboslexec/opspline.cpp View 1 7 chunks +23 lines, -12 lines 0 comments Download
testsuite/spline/ref/numknots.tif View 0 chunks +-1 lines, --1 lines 0 comments Download
testsuite/spline/ref/out.txt View 1 chunk +1 line, -0 lines 0 comments Download
testsuite/spline/run.py View 1 chunk +2 lines, -2 lines 0 comments Download
testsuite/spline/test.osl View 1 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
clifford.stein
14 years, 1 month ago (2010-03-08 21:41:26 UTC) #1
clifford.stein
removing knot-count limit
14 years, 1 month ago (2010-03-08 21:53:56 UTC) #2
ckulla
LGTM
14 years, 1 month ago (2010-03-08 22:03:26 UTC) #3
larrygritz
14 years, 1 month ago (2010-03-08 22:16:58 UTC) #4
LGTM, too.  I'll modify the docs.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b