Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(135)

Issue 306950043: Change spanner-id to be a key instead of a string (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 8 months ago by dak
Modified:
2 years, 4 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Change spanner-id to be a key instead of a string Also changes argument \= to be a key. This has been taken out from the ongoing work of Nathan Chou as a separate issue since it is a separate problem and needed a bit of polish. There are no convert-ly rules since stuff like \=3 or \="word" will still work due to type coercion. However, if spanner-id has been tweaked or overridden (possible as of 2.16), the type will now be wrong. It is rather hard to find good convert-ly rules for those so this issue/patch currently does not try. I might try figuring out some rules here (possibly based on pre-\= regression tests/code) in a separate issue but they are not likely to be overly reliable. Backport-by: David Kastrup <dak@gnu.org> Also contains: Changes entries for \= and in-chord slurs

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -30 lines) Patch
M Documentation/changes.tely View 1 chunk +19 lines, -0 lines 0 comments Download
M Documentation/notation/expressive.itely View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/slur-engraver.hh View 1 chunk +2 lines, -2 lines 0 comments Download
M lily/slur-engraver.cc View 7 chunks +10 lines, -12 lines 0 comments Download
M ly/grace-init.ly View 1 chunk +2 lines, -2 lines 0 comments Download
M ly/spanners-init.ly View 1 chunk +4 lines, -7 lines 0 comments Download
M scm/define-grob-properties.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-grobs.scm View 2 chunks +0 lines, -2 lines 0 comments Download
M scm/define-music-properties.scm View 1 chunk +1 line, -1 line 0 comments Download
M scm/define-music-types.scm View 2 chunks +0 lines, -2 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b