Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(136)

Issue 306350043: Web: home page: add examples/images, reduce news to headlines (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 7 months ago by pwm
Modified:
7 years, 6 months ago
Reviewers:
ul, paul, dak, carl.d.sorensen, mail, trevorbaca, fedelogy, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Web: home page: add examples/images, reduce news to headlines Examples/images is moved from the Introduction section to the home page.

Patch Set 1 #

Patch Set 2 : All 'Old news' -> 'News' & rearrange examples #

Patch Set 3 : One example on homepage with anchor links #

Total comments: 2

Patch Set 4 : Use Bach BWV861 example from essay #

Patch Set 5 : Remove image and ly files from patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+149 lines, -51 lines) Patch
M Documentation/ca/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ca/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/cs/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/cs/web.texi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/cs/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/css/lilypond-website.css View 1 2 3 4 3 chunks +25 lines, -14 lines 0 comments Download
M Documentation/de/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/de/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/es/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/web.texi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/fr/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/hu/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/it/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/ja/web/community.itexi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/nl/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/nl/web.texi View 1 1 chunk +1 line, -1 line 0 comments Download
M Documentation/web.texi View 1 2 3 2 chunks +54 lines, -5 lines 0 comments Download
M Documentation/web/community.itexi View 3 chunks +4 lines, -4 lines 0 comments Download
M Documentation/web/introduction.itexi View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M Documentation/web/news-front.itexi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A Documentation/web/news-headlines.itexi View 1 2 1 chunk +38 lines, -0 lines 0 comments Download
M Documentation/zh/macros.itexi View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Documentation/zh/web/community.itexi View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 29
pwm
Please review and let me know what you think about these changes. They are inspired ...
7 years, 7 months ago (2016-08-29 21:49:41 UTC) #1
fedelogy
On 2016/08/29 21:49:41, pwm wrote: > > The images and other content from the 'Examples' ...
7 years, 7 months ago (2016-08-30 15:07:47 UTC) #2
pwm
All 'Old news' -> 'News' & rearrange examples
7 years, 7 months ago (2016-08-30 20:02:14 UTC) #3
pwm
On 2016/08/30 15:07:47, fedelogy wrote: > > Paul, thanks for tackling this issue! Thanks, glad ...
7 years, 7 months ago (2016-08-30 20:51:37 UTC) #4
dak
paulwmorris@gmail.com writes: > On 2016/08/30 15:07:47, fedelogy wrote: > >> Paul, thanks for tackling this ...
7 years, 7 months ago (2016-08-30 21:52:47 UTC) #5
Carl
I'm not comfortable with the really long, scrolling, home page. I think we should make ...
7 years, 7 months ago (2016-08-30 22:05:11 UTC) #6
paul_paulwmorris.com
On 08/30/2016 06:05 PM, Carl.D.Sorensen@gmail.com wrote: > I'm not comfortable with the really long, scrolling, ...
7 years, 7 months ago (2016-08-31 15:39:03 UTC) #7
ul_openlilylib.org
Am 31. August 2016 16:11:14 MESZ, schrieb Paul <paul@paulwmorris.com>: >On 08/30/2016 06:05 PM, Carl.D.Sorensen@gmail.com wrote: ...
7 years, 7 months ago (2016-09-01 05:18:37 UTC) #8
pwm
One example on homepage with anchor links
7 years, 7 months ago (2016-09-06 15:13:52 UTC) #9
pwm
Patch set 3 uploaded, with just one example image on the home page and a ...
7 years, 7 months ago (2016-09-06 15:49:43 UTC) #10
ul_openlilylib.org
Am 06.09.2016 um 17:49 schrieb paulwmorris@gmail.com: > Patch set 3 uploaded, with just one example ...
7 years, 7 months ago (2016-09-06 16:09:50 UTC) #11
Carl
On 2016/09/06 15:49:43, pwm wrote: > Screenshot: > https://drive.google.com/open?id=0ByNTIEA63_a_ZzMtNTFiZHFqN2c > I have not built and ...
7 years, 7 months ago (2016-09-06 16:39:22 UTC) #12
simon.albrecht
My 2cts. https://codereview.appspot.com/306350043/diff/40001/Documentation/web.texi File Documentation/web.texi (right): https://codereview.appspot.com/306350043/diff/40001/Documentation/web.texi#newcode142 Documentation/web.texi:142: @exampleImage{bach-bwv610} I agree that we should look ...
7 years, 7 months ago (2016-09-06 19:47:57 UTC) #13
pwm
Thanks for the feedback everyone! On 2016/09/06 16:39:22, Carl wrote: > > I think the ...
7 years, 7 months ago (2016-09-08 03:28:49 UTC) #14
mail_philholmes.net
----- Original Message ----- From: <paulwmorris@gmail.com> To: <fedelogy@gmail.com>; <dak@gnu.org>; <carl.d.sorensen@gmail.com>; <paul@paulwmorris.com>; <ul@openlilylib.org>; <simon.albrecht@mail.de> Cc: <reply@codereview-hr.appspotmail.com>; ...
7 years, 7 months ago (2016-09-08 08:12:12 UTC) #15
Carl
On 2016/09/08 03:28:49, pwm wrote: > Thanks for the feedback everyone! > > On 2016/09/06 ...
7 years, 7 months ago (2016-09-08 16:53:49 UTC) #16
paul_paulwmorris.com
On 09/08/2016 12:53 PM, Carl.D.Sorensen@gmail.com wrote: > How about the BWV 861 example from the ...
7 years, 7 months ago (2016-09-13 00:25:23 UTC) #17
mail_philholmes.net
----- Original Message ----- From: "Paul" <paul@paulwmorris.com> To: <paulwmorris@gmail.com>; <fedelogy@gmail.com>; <dak@gnu.org>; <carl.d.sorensen@gmail.com>; <ul@openlilylib.org>; <simon.albrecht@mail.de>; <mail@philholmes.net>; ...
7 years, 7 months ago (2016-09-13 08:28:48 UTC) #18
paul_paulwmorris.com
On 09/13/2016 04:28 AM, Phil Holmes wrote: > I know understanding how images are used ...
7 years, 7 months ago (2016-09-13 13:26:39 UTC) #19
mail_philholmes.net
----- Original Message ----- From: "Paul" <paul@paulwmorris.com> To: "Phil Holmes" <mail@philholmes.net>; <paulwmorris@gmail.com>; <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: ...
7 years, 7 months ago (2016-09-13 13:53:13 UTC) #20
mail_philholmes.net
----- Original Message ----- From: "Paul" <paul@paulwmorris.com> To: "Phil Holmes" <mail@philholmes.net>; <paulwmorris@gmail.com>; <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: ...
7 years, 7 months ago (2016-09-13 14:02:23 UTC) #21
paul_paulwmorris.com
On 09/13/2016 10:02 AM, Phil Holmes wrote: > Just thinking about this bit some more ...
7 years, 7 months ago (2016-09-13 14:41:45 UTC) #22
paul_paulwmorris.com
On 09/13/2016 09:52 AM, Phil Holmes wrote: >> At this point it would probably be ...
7 years, 7 months ago (2016-09-13 14:42:15 UTC) #23
mail_philholmes.net
----- Original Message ----- From: "Paul" <paul@paulwmorris.com> To: "Phil Holmes" <mail@philholmes.net>; <paulwmorris@gmail.com>; <lilypond-devel@gnu.org>; <reply@codereview-hr.appspotmail.com> Sent: ...
7 years, 7 months ago (2016-09-13 15:19:22 UTC) #24
pwm
Use Bach BWV861 example from essay
7 years, 7 months ago (2016-09-15 00:43:03 UTC) #25
pwm
Now using the Bach BWV861 example from the essay. Screenshot: https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0 I like the cleaner ...
7 years, 7 months ago (2016-09-15 00:51:08 UTC) #26
ul_openlilylib.org
Am 15.09.2016 um 02:51 schrieb paulwmorris@gmail.com: > Now using the Bach BWV861 example from the ...
7 years, 7 months ago (2016-09-15 04:42:19 UTC) #27
pwm
Remove image and ly files from patch
7 years, 7 months ago (2016-09-16 16:32:23 UTC) #28
trevorbaca_gmail.com
7 years, 6 months ago (2016-10-03 20:46:15 UTC) #29
On Wed, Sep 14, 2016 at 11:42 PM, Urs Liska <ul@openlilylib.org> wrote:

>
>
> Am 15.09.2016 um 02:51 schrieb paulwmorris@gmail.com:
> > Now using the Bach BWV861 example from the essay.  Screenshot:
> > https://drive.google.com/open?id=0ByNTIEA63_a_ZGZrZzlkSUhJeU0
> >
> > I like the cleaner look since this image doesn't have any title, text,
> > etc. like the previous one.  If you click on the image you can see a
> > larger version.  I will upload the pngs to gperciva/lilypond-extra
> >
>
> I like that solution.
>
> One question: Is that example done without any tweaks? I think so but
> want to make sure. If it is it would be worth a mention on the front
> page about "automatic engraving", which is one of the main points for
> using LilyPond.


The newer, cleaner homepage is a great improvement.

Was lovely to see beautiful engraving straightaway this morning on going to
the site!


Trevor.

-- 
Trevor Bača
www.trevorbaca.com
soundcloud.com/trevorbaca
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b