Issue 3040041: Add function comments to bus/server.[ch]

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3040041: Add function comments to bus/server.[ch] (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
13 years, 7 months ago by Yusuke Sato

Modified:
13 years, 7 months ago

Reviewers:
shawn.p.huang, Peng Huang

Base URL:
git@github.com:ibus/ibus.git@master

Visibility:
Public.

Description

Add function comments to bus/server.[ch] BUG=none TEST=none

Patch Set 2 : review fix #

Created: 13 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -4 lines)			Patch
	M	bus/server.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
	M	bus/server.c	View	1	5 chunks	+21 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Yusuke Sato

http://codereview.appspot.com/3040041/diff/2001/bus/server.c File bus/server.c (right): http://codereview.appspot.com/3040041/diff/2001/bus/server.c#newcode106 bus/server.c:106: Question: isn't it better to call g_object_unref(dbus); g_object_unref(ibus); dbus ...

13 years, 7 months ago (2010-11-15 04:16:30 UTC) #1

Peng

LGTM http://codereview.appspot.com/3040041/diff/2001/bus/server.c File bus/server.c (right): http://codereview.appspot.com/3040041/diff/2001/bus/server.c#newcode72 bus/server.c:72: g_free (guid); Maybe one parameter per line looks ...

13 years, 7 months ago (2010-11-15 06:09:02 UTC) #2

Yusuke Sato

13 years, 7 months ago (2010-11-15 08:39:12 UTC) #3

fixed. submitting...

http://codereview.appspot.com/3040041/diff/2001/bus/server.c
File bus/server.c (right):

http://codereview.appspot.com/3040041/diff/2001/bus/server.c#newcode72
bus/server.c:72: g_free (guid);
On 2010/11/15 06:09:02, Shawn.P.Huang wrote:
> Maybe one parameter per line looks better.

Done.

Expand All Messages | Collapse All Messages