Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4618)

Issue 303980043: 4919: beam 1/20 and shorter notes by 1/4 in 2/2 and 3/2 time

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by simon.albrecht
Modified:
7 years, 9 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

4919: beam 1/20 and shorter notes by 1/4 in 2/2 and 3/2 time Else 10 or more notes end up on a beam by default, which is hard to read and unusual.

Patch Set 1 #

Patch Set 2 : Add regtest coverage. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -5 lines) Patch
M input/regression/autobeam-show-defaults.ly View 1 2 chunks +4 lines, -1 line 0 comments Download
M scm/time-signature-settings.scm View 1 chunk +4 lines, -4 lines 1 comment Download

Messages

Total messages: 4
dak
Since this is supposed to be an improvement in typesetting, it would seem rather appropriate ...
7 years, 9 months ago (2016-07-04 17:55:57 UTC) #1
simon.albrecht
Add regtest coverage.
7 years, 9 months ago (2016-07-04 18:45:05 UTC) #2
dak
Ok, so this example makes clear the effect in 2/2 and 3/2 meters. Thing is, ...
7 years, 9 months ago (2016-07-04 20:21:41 UTC) #3
dak
7 years, 9 months ago (2016-07-22 06:20:32 UTC) #4
https://codereview.appspot.com/303980043/diff/20001/scm/time-signature-settin...
File scm/time-signature-settings.scm (right):

https://codereview.appspot.com/303980043/diff/20001/scm/time-signature-settin...
scm/time-signature-settings.scm:73: ((beamExceptions . ((end . ((1/20 . (5 5 5
5))))))))
Well, the other exceptions tend to draw the line differently (see 6/4, 9/4,
12/4, and the somewhat different 3/4 and 4/4 resume beat-beaming at triplets
rather than smaller).  One problem with quintuplets are that they are
indistinguishable from decemtuplets in the exception rules.

Take for example

\score {
  \fixed c'
  {
    \time 2/2
    \tuplet 10/8 2 { c16 d e g f d g f e d
		     c g e d f e g f d e }
    c1
  }

  \layout {}
  \midi { \tempo 2 = 60 }
}

under old and proposed rules.  So I think that when changing the
autobeaming rules, we should try to keep LilyPond's defaults somewhat
consistent and predictable and not arbitrarily draw the tuplet lines
differently for every meter.

I particularly don't see why quintuplets at 3/2 should be treated differently
than at 6/4 as compared to triplets.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b