Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(733)

Issue 303650043: Add annotation of \shape-d curves (WIP)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 6 months ago by git
Modified:
7 years, 5 months ago
Reviewers:
simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add annotation of \shape-d curves (WIP) This code is not ready for inclusion because I need some help. Basically I'm happy with what it does, but I don't know how to make it support broken slurs as well. Additionally I don't understand how \shape works as a post-event, and it doesn't work yet. (I'll update the documentation once the patch is ready for inclusion.) Actually I would like to define some of the functions not as local functions but as globally available routines because the \compoundSlur code will be able to use it, and it will make it easier to later incorporate \compoundSlur as well. - Add optional first boolean argument to turn on annotation - print control points with connection to end points - print (lightly) original slur with control points Limitations: - doesn't work with broken spanners yet - doesn't work when item is not present

Patch Set 1 #

Total comments: 1

Patch Set 2 : Re-commit without the reformatting #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -36 lines) Patch
M ly/music-functions-init.ly View 1 1 chunk +101 lines, -36 lines 2 comments Download

Messages

Total messages: 3
simon.albrecht
Hi Urs, please resubmit the patch without reformatting. https://codereview.appspot.com/303650043/diff/1/ly/music-functions-init.ly File ly/music-functions-init.ly (right): https://codereview.appspot.com/303650043/diff/1/ly/music-functions-init.ly#newcode30 ly/music-functions-init.ly:30: (ice-9 ...
7 years, 5 months ago (2016-09-22 12:14:39 UTC) #1
git
Re-commit without the reformatting
7 years, 5 months ago (2016-09-22 21:40:39 UTC) #2
simon.albrecht
7 years, 5 months ago (2016-09-22 22:20:03 UTC) #3
https://codereview.appspot.com/303650043/diff/20001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):

https://codereview.appspot.com/303650043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:1646: present and set to @code{##t} the control
points, the original shape
‘and set to @code{##t}COMMA, …’

https://codereview.appspot.com/303650043/diff/20001/ly/music-functions-init.l...
ly/music-functions-init.ly:1672: (car origin) (cdr origin) (car pt) (cdr pt))))
the ly:stencil-add is superfluous here, isn’t it?
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b