Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(871)

Issue 3014041: make gadget.util a singleton which will not impact the iframe rendering

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 4 months ago by qiaoysun
Modified:
13 years ago
Base URL:
http://svn.apache.org/repos/asf/shindig/trunk/
Visibility:
Public.

Description

When rendering a gadget inline, registerOnLoadHandler and runOnLoadHandlers are impacted : this two functions used an array "onLoadHandlers" to store and read the registered handlers and this is a locally variable. When rendering in iframe, the outside util and inside util are isolated, all theirs registered handler will be run. But when rendering inline, the inside util will rewrite the outside util due to the context merge issue described above, so the outside util's registered handler will not be run. if make gadgets.util, there is only one gadgets.util, and iframe rendering can't be effected, as it still will create one in the gadget.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
features/src/main/javascript/features/core.util/util.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3
qiaoysun
13 years, 4 months ago (2010-11-10 10:06:19 UTC) #1
plindner1
I tried this patch and found failures in the features jsunit tests. Can you check ...
13 years, 3 months ago (2010-12-20 09:42:14 UTC) #2
Paul Lindner
13 years ago (2011-04-01 06:05:32 UTC) #3
ping...

On 2010/12/20 09:42:14, plindner1 wrote:
> I tried this patch and found failures in the features jsunit tests.
> 
> Can you check this?
> 
> It seems that gadgets.rpc uses a different method to preserve against
> double-inclusion..
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b