Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3219)

Issue 301070043: ADD_ACKNOWLEDGER/LISTENER_FOR

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 10 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

ADD_ACKNOWLEDGER/LISTENER_FOR Add macros allowing to listen/acknowledge to events/grobs unrelated to the actual listener name. This is actually conflating a few issues tampering with the same code. If review is unhappy about some parts, they can still be split out and treated separately. Also contains commits: Use ADD_END_ACKNOWLEDGER_FOR in slur engravers Don't let ADD_END_ACKNOWLEDGER_FOR add end_ to callback [Note that those two commits might be a bit contentious. They make it possible to get rid of Slur::acknowledge_end_tie as a stub calling Slur::acknowledge_extra_object. The savings are not exactly overwhelming, but there does not seem to be any other use of ADD_END_ACKNOWLEDGER_FOR otherwise] Use ADD_LISTENER/ACKNOWLEDGER_FOR in slur engravers Rename ack_trampoline to trampoline This allows foregoing a dummy Translator::ack_trampoline definition. Rename ack_finder to method_finder This additional overload streamlines things somewhat. [Those last two commits are independent changes but touch the same code lines]

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -95 lines) Patch
M lily/include/engraver.hh View 1 chunk +2 lines, -1 line 0 comments Download
M lily/include/slur-engraver.hh View 1 chunk +0 lines, -6 lines 0 comments Download
M lily/include/translator.hh View 3 chunks +4 lines, -13 lines 0 comments Download
M lily/include/translator.icc View 1 chunk +17 lines, -8 lines 0 comments Download
M lily/phrasing-slur-engraver.cc View 2 chunks +8 lines, -25 lines 0 comments Download
M lily/slur-engraver.cc View 3 chunks +6 lines, -42 lines 0 comments Download

Messages

Total messages: 1
Dan Eble
7 years, 10 months ago (2016-06-28 02:10:10 UTC) #1
LGTM.  The wart in ADD_END_ACKNOWLEDGER seems like a fair trade for simplifying
the engraver code.  I don't have any better idea.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b