Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4407)

Issue 300930043: Fix ly:format for the string that contain zero

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by trueroad
Modified:
7 years, 10 months ago
Reviewers:
dak
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Fix ly:format for the string that contain zero strcpy and strncpy cannot be used in std::string concatenation because std::string may contain '\0' in its contents. In order to avoid problems with string that contains '\0', this commit replaces the strncpy to std::string::copy.

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M lily/general-scheme.cc View 1 chunk +3 lines, -1 line 1 comment Download

Messages

Total messages: 3
dak
https://codereview.appspot.com/300930043/diff/1/lily/general-scheme.cc File lily/general-scheme.cc (left): https://codereview.appspot.com/300930043/diff/1/lily/general-scheme.cc#oldcode598 lily/general-scheme.cc:598: strncpy (ptr, results[i].c_str (), results[i].size ()); I've suspected this ...
7 years, 10 months ago (2016-06-10 14:16:29 UTC) #1
trueroad
A font embedding is no problem. An EPS embedding was the problem. `aaa-eps.eps` contains `\0` ...
7 years, 10 months ago (2016-06-10 16:30:18 UTC) #2
trueroad
7 years, 10 months ago (2016-06-15 15:14:18 UTC) #3
I've pushed to staging.

Issue 4890: Fix ly:format for the string that contain zero
commit 211634be6f90db700eb8e5725046b27aa153ee92
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b