Issue 3005: patch for bug 1878 - turn Py_TPFLAGS_HAVE_VERSION_TAG off when not building the core

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3005: patch for bug 1878 - turn Py_TPFLAGS_HAVE_VERSION_TAG off when not building the core (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by GvR

Modified:
14 years, 8 months ago

Reviewers:
Benjamin

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

Description

r65874.

Patch Set 1 #

Patch Set 2 : clear trailing whitespace #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -6 lines)			Patch
		Include/object.h	View	1	5 chunks	+15 lines, -6 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

GvR

Please review this, or I'll just submit it in an hour or so...

15 years, 8 months ago (2008-08-19 19:27:46 UTC) #1

Benjamin

15 years, 8 months ago (2008-08-19 19:34:26 UTC) #2

Looks basically fine to me.

http://codereview.appspot.com/3005/diff/1/2
File Include/object.h (right):

http://codereview.appspot.com/3005/diff/1/2#newcode531
Line 531: Py_TPFLAGS_HAVE_VERSION_TAG; outside the core, it doesn't.)
Perhaps you should explain why somewhere.

Expand All Messages | Collapse All Messages