Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(32)

Issue 300300043: Issue 2232: fix MIDI output of abutting (de)crescendi (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by Dan Eble
Modified:
7 years, 9 months ago
Reviewers:
ht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Is it really this easy? I checked the velocity of the output MIDI by inspecting the notes in Aria Maestosa.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
A input/regression/midi/crescendo-abutting.ly View 1 chunk +10 lines, -0 lines 0 comments Download
M lily/dynamic-performer.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2
ht
Do I understand correctly that this change in effect automatically replaces every { ... CC ...
7 years, 9 months ago (2016-06-07 19:07:40 UTC) #1
Dan Eble
7 years, 9 months ago (2016-06-07 21:41:13 UTC) #2
On 2016/06/07 19:07:40, ht wrote:
> Do I understand correctly that this change in effect automatically replaces
> every { ... CC ... DD ... } (where CC and DD can be either \< or \>, with no
> (de)crescendo events between them) with { ... CC ... \! DD ... }

That is my understanding.

> With the patch I get an "Impossible or ambiguous (de)crescendo in MIDI"
warning
> from this example, though

That probably falls under https://sourceforge.net/p/testlilyissues/issues/4048/
.

Thanks for your review and the example.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b