Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(256)

Issue 2994042: Remove include of SkGLDevice.h from SkGLCanvas.h (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
13 years, 8 months ago by Steve VanDeBogart
Modified:
13 years, 8 months ago
Reviewers:
CC:
skia-review_googlegroups.com
Base URL:
http://skia.googlecode.com/svn/trunk
Visibility:
Public.

Description

Remove include of SkGLDevice.h from SkGLCanvas.h The '#include "SkGLDevice.h"' from include/core/SkDevice.h requires internal Skia code to be added to the include search paths when using the deprecated API. This change adds back SkGLCanvas.cpp to avoid exposing SkGLDevice.h to the public API. The change also includes an explicit virtual destructor on SkDeviceFactory to silence a -Wnon-virtual-dtor warning and allow for -Werror. Original Issue: http://codereview.appspot.com/3009041/ Committed: http://code.google.com/p/skia/source/detail?r=623

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -27 lines) Patch
M include/core/SkDevice.h View 2 chunks +2 lines, -1 line 0 comments Download
M include/utils/SkGLCanvas.h View 2 chunks +12 lines, -26 lines 0 comments Download
M src/core/SkDevice.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
A src/gl/SkGLCanvas.cpp View 1 chunk +50 lines, -0 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b