Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1675)

Issue 298830043: Create Translator_creator class (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years ago by dak
Modified:
7 years, 11 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Create Translator_creator class Previously, translators were created by copying from a context-less instantiation of the translator containing its documentation. This had several unpleasant consequences, the most problematic likely being the inability to register Scheme engravers because their documentation would be identical to all other Scheme engravers. A new Translator_creator class takes over the task of creating Translator instances. Another step towards solving issue 1375.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+120 lines, -75 lines) Patch
lily/context-def.cc View 1 chunk +1 line, -1 line 0 comments Download
lily/include/lily-proto.hh View 1 chunk +1 line, -0 lines 0 comments Download
M lily/include/performer.hh View 1 chunk +0 lines, -1 line 0 comments Download
lily/include/translator.hh View 5 chunks +48 lines, -19 lines 0 comments Download
lily/include/translator.icc View 2 chunks +26 lines, -24 lines 0 comments Download
lily/translator.cc View 4 chunks +6 lines, -15 lines 0 comments Download
M lily/translator-ctors.cc View 4 chunks +34 lines, -10 lines 0 comments Download
lily/translator-group.cc View 3 chunks +3 lines, -4 lines 0 comments Download
lily/translator-scheme.cc View 1 chunk +1 line, -1 line 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b