Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3544)

Issue 298660043: Remove some set_location calls from parser

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 9 months ago by dak
Modified:
7 years, 9 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Remove some set_location calls from parser Older versions of Bison (current is 3.0.4) had problems assigning location data to rules with empty production, possibly related to the definition of YYLLOCA_DEFAULT when N is zero. This lead to several workarounds in the code base. A number of them dropped through the floor in the course of refactoring without apparent problem, and the original problem does not appear to be reproducible with the current versions of Bison. This removes the remaining instances. Should the original problem reoccur at some point of time (or with some versions of Bison), it would be noticeable as bad point-and-click messages and/or error messages with bad location data.

Patch Set 1 #

Patch Set 2 : typo fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M lily/parser.yy View 1 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 1
dak
7 years, 9 months ago (2016-07-04 19:24:51 UTC) #1
typo fix
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b