Issue 297990043: Make Translator/Performer/Engraver abstract base classes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 297990043: Make Translator/Performer/Engraver abstract base classes (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 11 months ago by pkx166h

Modified:
6 years, 7 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Make Translator/Performer/Engraver abstract base classes It does not make sense for them to be instantiable.

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -34 lines)			Patch
M	lily/engraver.cc	View	1 chunk	+0 lines, -17 lines	0 comments	Download
M	lily/include/engraver.hh	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	lily/include/performer.hh	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/include/scheme-engraver.hh	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	lily/include/translator.hh	View	2 chunks	+8 lines, -1 line	0 comments	Download
M	lily/include/translator.icc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/translator.cc	View	1 chunk	+1 line, -13 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

pkx166h

6 years, 7 months ago (2017-09-14 08:48:43 UTC) #1

Pushed to staging as
commit e035fded640056dcdf0b202a0156997c2295865e
Author: David Kastrup dak@gnu.org
Date: Mon May 2 16:26:20 2016 +0200

Issue 4840: Make Translator/Performer/Engraver abstract base classes

It does not make sense for them to be instantiable.

Expand All Messages | Collapse All Messages