Issue 297370043: Make additional changes to the new version of musicxml2ly

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 297370043: Make additional changes to the new version of musicxml2ly (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 11 months ago by john3

Modified:
7 years, 10 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Make additional changes to the new version of musicxml2ly imported from the Philomelos project. The changes are also uploaded to the branch dev/johngourlay/issue-4751. After these changes I can run the following build commands without error: make make test-clean make test make check The problems with the earlier patch were due to my misunderstanding of the make test dependencies. I did not run make test-clean, and so I did not see that some musicxml regression tests did not run.

Patch Set 1 #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3760 lines, -2169 lines)			Patch
M	python/musicexp.py	View	65 chunks	+604 lines, -156 lines	0 comments	Download
M	python/musicxml.py	View	13 chunks	+1201 lines, -662 lines	0 comments	Download
A	python/musicxml2ly_conversion.py	View	1 chunk	+53 lines, -0 lines	0 comments	Download
A	python/utilities.py	View	1 chunk	+268 lines, -0 lines	0 comments	Download
M	scripts/musicxml2ly.py	View	45 chunks	+1634 lines, -1351 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

john3

7 years, 11 months ago (2016-05-30 22:10:12 UTC) #1

A few days a go I uploaded a new patch for issue 4751, "Import Philolelos
enhancements to musicxml2ly", the first patch for which had been flagged as
needing work. I hope this version works better.

Expand All Messages | Collapse All Messages