Add halfopenvertical to script.scm

Add halfopenvertical to script.scm

[thomasmorley651, 2016-05-23 22:21:01]

Fine with me for script.scm

Not sure about the regtest, though.
Testing (new) articulations with a custom drumStyleTable is a nice idea.
Though, testing all available articulations (isn't covered currently as far as I
know) this way would be far too much, imho.
How about something at the lines of:

arts = #(cons "halfopenvertical" (map car default-script-alist))

\markup \wordwrap-string #(string-join (cons "Tested:" (sort arts string-ci<?)))

$(make-sequential-music 
  (map
    (lambda (art)
      #{
        \withMusicProperty #'articulations 
          #(list (make-music
                   'ArticulationEvent
                   'articulation-type
                   art)
                 (make-music
                   'TextScriptEvent
                   'direction 1
                   'text (markup #:fontsize -4 art)))
      c''1
      #})
  (sort arts string-ci<?)))

This will return an assertion failure for 2.18.2 (halfopenvertical not in
default-script-alist), but ofcourse it can't grab other oversights, if any.

[Carl, 2016-05-24 23:57:38]

It seems to me that if we want to make this kind of a regtest we should really
be looking at all TextScripts that are supposed to be articulations, and seeing
if the articulations work.

The regtest you proposed looks at all the articulations we have defined, and
sees if they properly print out.  This regtest would not have caught the error I
made, because the problem was I didn't add it to the articulation list.

I think the regtest you proposed has some potential value, but I don't think it
should be tied to this issue.

The challenge is that some of the feta font elements in the scripts.* familiy
are used as articulations, while others (e.g. caesura) are not.  And the ones
not used as articulations are not included in script.scm by choice.

Maybe we could add a field to the NR Appendix A.8 [1] that is the articulation
used for each of the scripts.  And for those that had no entry it would say
something like "Not used as articulation".

Thanks for the careful thought!

Carl

1.
http://lilypond.org/doc/v2.19/Documentation/notation/the-feta-font#script-glyphs

[Carl, 2016-05-25 00:03:44]

On 2016/05/24 23:57:38, Carl wrote:

> 
> The challenge is that some of the feta font elements in the scripts.* familiy
> are used as articulations, while others (e.g. caesura) are not.  And the ones
> not used as articulations are not included in script.scm by choice.


I guess my wording was bad.  It's not a question of use as articulations.  It's
a question of being part of the Score context property scriptDefinitions.  And
I'm not sure what the criteria are for including a scripts.* glyph in the
scriptDefinitions property.  So I think I don't know exactly what the right
thing to do here is.  I'd welcome any input.

Thanks,

Carl

[Carl, 2016-06-12 13:34:37]

Fix documentation error.  Now passes make and make doc on my machine

[Carl, 2016-06-12 13:40:27]

The error that was identified in make doc actually resolves the problem Harm was
concerned about. If a script is added to scripts.scm as an articulation, and
that articulation is not added to Documentation/included/script-chart.ly, then
make doc fails.

So I think we are covered for some automated method of verifying that all
articulations listed in scripts.scm is in fact tested by the build process
(although not in the regression tests).

Thanks,

Carl