Issue 2968: Review of patch for issue3474

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2968: Review of patch for issue3474 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by brett.cannon

Modified:
14 years, 9 months ago

Reviewers:
brett

CC:
Benjamin

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

Description

Patch from Benjamin for issue3474 to minimize code duplication.

Patch Set 1 #

Downloaded from: http://bugs.python.org/file11120/import_from_functools.diff

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -56 lines)			Patch
		Python/bltinmodule.c	View		1 chunk	+10 lines, -56 lines	1 comment	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

brett.cannon

15 years, 8 months ago (2008-08-18 01:53:54 UTC) #2

Only one minor change I would make. Otherwise it looks ready to be committed.

http://codereview.appspot.com/2968/diff/1/2
File Python/bltinmodule.c (right):

http://codereview.appspot.com/2968/diff/1/2#newcode2011
Line 2011: PyObject *functools = PyImport_ImportModule("_functools");
Probably best to just import functools directly then mess around with
implementation details.

Expand All Messages | Collapse All Messages