Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(8015)

Issue 296470043: Allow multiple \with per context creation

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by dak
Modified:
7 years, 10 months ago
Reviewers:
Dan Eble
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Allow multiple \with per context creation This allows using more than one \with context modification in connection with \new, \context, \addlyrics, \drums, \lyrics, \chords, \figures . While combining them inside of a single \with {...} is possible, sometimes it may be inconvenient.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Added some comments. Dan's proposed names were not following any inner logic, so not taken. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -36 lines) Patch
M lily/parser.yy View 1 3 chunks +40 lines, -36 lines 0 comments Download

Messages

Total messages: 2
Dan Eble
LGTM https://codereview.appspot.com/296470043/diff/1/lily/parser.yy File lily/parser.yy (right): https://codereview.appspot.com/296470043/diff/1/lily/parser.yy#newcode1497 lily/parser.yy:1497: context_modification_mods_list: Comments as simple as these would help ...
7 years, 10 months ago (2016-06-18 12:42:19 UTC) #1
dak
7 years, 10 months ago (2016-06-19 11:02:43 UTC) #2
Added some comments.  Dan's proposed names were not following any inner logic,
so not taken.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b