Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(941)

Issue 296350043: Add ly:get-font-format to get the font format

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by trueroad
Modified:
7 years, 9 months ago
Reviewers:
lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add ly:get-font-format to get the font format Most of the OpenType/CFF Collection (OTC) fonts have the extension `*.ttc'. TrueType Collection (TTC) fonts also have the same extension `*.ttc'. However, it is necessary that different embed method, between OTC and TTC. So we need to distinguish them. This commit adds ly:get-font-format that can get font format for distinguishing them.

Patch Set 1 #

Total comments: 1

Patch Set 2 : Use symbol instead of string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -0 lines) Patch
M lily/open-type-font-scheme.cc View 1 2 chunks +57 lines, -0 lines 0 comments Download

Messages

Total messages: 9
lemzwerg
You were faster than me :-) LGTM, but note that FreeType's `FT_Get_Font_Format` doesn't really return ...
7 years, 10 months ago (2016-06-03 20:06:49 UTC) #1
trueroad
Use symbol instead of string
7 years, 9 months ago (2016-06-04 10:17:09 UTC) #2
trueroad
> LGTM, but note that FreeType's `FT_Get_Font_Format` doesn't really return the > font format but ...
7 years, 9 months ago (2016-06-04 10:31:47 UTC) #3
lemzwerg
> My main purpose was the distinction between the TTC and OTC. > So this ...
7 years, 9 months ago (2016-06-04 21:35:19 UTC) #4
trueroad
> > My main purpose was the distinction between the TTC and OTC. > > ...
7 years, 9 months ago (2016-06-05 10:02:54 UTC) #5
trueroad
> It does not seem difficult that determine whether PFA or PFB. > Like this: ...
7 years, 9 months ago (2016-06-05 13:28:30 UTC) #6
lemzwerg
> Rewriting `ly:pfb->pfa' to `ly:type1->pfa'. > For PFA fonts, it passes through the PFA. > ...
7 years, 9 months ago (2016-06-07 04:07:49 UTC) #7
trueroad
On 2016/06/07 04:07:49, lemzwerg wrote: > > Rewriting `ly:pfb->pfa' to `ly:type1->pfa'. > > For PFA ...
7 years, 9 months ago (2016-06-07 15:32:52 UTC) #8
trueroad
7 years, 9 months ago (2016-06-09 14:57:14 UTC) #9
I've pushed to staging.

commit 887eee27389862497fd4754f24348c1d77c91999
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b