Issue 296310043: Give add_acknowledger SCM &, not Protected_scm &

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 296310043: Give add_acknowledger SCM &, not Protected_scm & (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by dak

Modified:
2 years, 4 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Give add_acknowledger SCM &, not Protected_scm & This one annoyed me, this looks cleaner. Also contains commit: operator SCM & () for Protected_scm This allows passing SCM reference parameters that are actually based on Protected_scm.

Patch Set 1 #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+30 lines, -14 lines)			Patch
M	lily/include/protected-scm.hh	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	lily/include/translator.icc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lily/protected-scm.cc	View	3 chunks	+24 lines, -10 lines	0 comments	Download
M	lily/translator.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download