Issue 295490043: Replace Grace_beam_engraver::listen_beam

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 295490043: Replace Grace_beam_engraver::listen_beam

Can't Edit
Can't Publish+Mail
Start Review

Created:
7 years, 10 months ago by dak

Modified:
7 years, 10 months ago

Reviewers:

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Replace Grace_beam_engraver::listen_beam The comment for it complains about copy&paste code, but the actual code for Beam_engraver::listen_beam has evolved since then and the changes, while seeming appropriate for the Grace_beam_engraver as well, have not been copied over. Deleting the listener callback and instead utilizing the one from the base class Beam_engraver seems like the sanest course of action.

Patch Set 1 #

Patch Set 2 : Rebase on current master #

Patch Set 3 : Rebase on current master #

Created: 7 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -18 lines)			Patch
	M	lily/beam-engraver.cc	View	1	4 chunks	+2 lines, -18 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Rebase on current master

Expand All Messages | Collapse All Messages