Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14612)

Issue 295470043: Revert #4747: (Remove (all) uses of is-absolute?

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 10 months ago by git
Modified:
7 years, 10 months ago
Reviewers:
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Revert #4747: (Remove (all) uses of is-absolute? This reverts commit f30a8189adbbeefa2103e2c2e194040f66bc2291 Author: Urs Liska <ul@openlilylib.org> Date: Tue Jan 19 10:52:33 2016 +0100 #4747: Remove (all) uses of is-absolute? ==================== As discussion revealed the commit message is not true and indicates a misconception (see quote below). (car ly:input-file-line-char-column a-location) does *not* always return an absolute path, instead this depends on how the file path has been passed to LilyPond. As this commit changed the behaviour of point-and-click in a somewhat unintentional and unmaintainable way it is better to revert the commit. Especially as the original behaviour was not harmful in the first place. ======================== (Original commit message:) The check for absolute paths in in output-ps.scm and -svg.scm is unnecessary because (car ly:input-file-line-char-column a-location) always returns an absolute, slashified path Now is-absolute? is not used anymore by LilyPond itself.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M scm/output-ps.scm View 2 chunks +5 lines, -1 line 0 comments Download
M scm/output-svg.scm View 1 chunk +8 lines, -4 lines 0 comments Download

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b