Issue 2948: Deletable attributes in PySystemState

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 2948: Deletable attributes in PySystemState

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 8 months ago by Nicholas Riley

Modified:
9 years, 4 months ago

Reviewers:
fwierzbicki

Base URL:
https://jython.svn.sourceforge.net/svnroot/jython/branches/asm/

Visibility:
Public.

Patch Set 1 #

Created: 15 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+79 lines, -22 lines)			Patch
		Lib/test/test_sys_jy.py	View		2 chunks	+23 lines, -3 lines	0 comments	Download
		src/org/python/core/PySystemState.java	View		5 chunks	+56 lines, -19 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

fwierzbicki

15 years, 8 months ago (2008-08-16 13:55:03 UTC) #1

http://codereview.appspot.com/2948/diff/1/2
File src/org/python/core/PySystemState.java (right):

http://codereview.appspot.com/2948/diff/1/2#newcode213
Line 213: return ret; // xxx hack
Maybe a little more detail about why this is a hack -- what does this work
around?

Expand All Messages | Collapse All Messages