Issue 294610043: Bug 1274811 - Defer client auth callback until server cert is available

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 294610043: Bug 1274811 - Defer client auth callback until server cert is available (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 years, 11 months ago by mt

Modified:
9 years, 8 months ago

Reviewers:
ttaubert, ekr-rietveld

Visibility:
Public.

More Reviews

Description

Bug 1274811 - Defer client auth callback until server cert is available

Patch Set 2 : Changing memory management #

Patch Set 3 : Removing unnecessary check #

Created: 9 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+101 lines, -58 lines)			Patch
M	external_tests/ssl_gtest/tls_agent.cc	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
M	lib/ssl/ssl3con.c	View	1	6 chunks	+17 lines, -12 lines	0 comments	Download
M	lib/ssl/sslimpl.h	View	1	2 chunks	+10 lines, -4 lines	0 comments	Download
M	lib/ssl/tls13con.c	View	1 2	5 chunks	+72 lines, -42 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

ttaubert

https://codereview.appspot.com/294610043/diff/1/external_tests/ssl_gtest/tls_agent.cc File external_tests/ssl_gtest/tls_agent.cc (right): https://codereview.appspot.com/294610043/diff/1/external_tests/ssl_gtest/tls_agent.cc#newcode185 external_tests/ssl_gtest/tls_agent.cc:185: << "Client should be able to look at the ...

9 years, 11 months ago (2016-05-23 09:51:40 UTC) #1

ekr-rietveld

LGTM https://codereview.appspot.com/294610043/diff/1/lib/ssl/ssl3con.c File lib/ssl/ssl3con.c (right): https://codereview.appspot.com/294610043/diff/1/lib/ssl/ssl3con.c#newcode11107 lib/ssl/ssl3con.c:11107: context->len, 1); Why not make context point to ...

9 years, 10 months ago (2016-07-04 00:08:18 UTC) #2

9 years, 9 months ago (2016-07-11 01:18:10 UTC) #3

I rebased, which will make this look bad, but the changes are simple.

https://codereview.appspot.com/294610043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/294610043/diff/1/lib/ssl/ssl3con.c#newcode11107
lib/ssl/ssl3con.c:11107: context->len, 1);
On 2016/07/04 00:08:17, ekr-webrtc wrote:
> Why not make context point to a dummy instead? Then you could save this switch
> and just free the certRequestArena later

Not a bad idea.  I realized that I wasn't freeing the arena when an empty
certificate was sent.  It actually makes more sense to free it in
tls13_SendClientSecondRound() when you realize that.

Expand All Messages | Collapse All Messages