PDF: Add text support with a font framework (font embedding to come).

PDF: Add text support with a font framework (font embedding to come).

Supports fakeBold, underline, strikethrough, mode (fill, stroke, both), size, skew, alignment (left, center, right).
Missing is drawFontOnPath and font lookup and embedding.
Changed SkPDFString to support how it is used from drawText methods.
Moved compile assert into SkTypes.
Moved constants and utility function used to support fakeBold, underline, and strikethrough into higher level locations.

Committed: http://code.google.com/p/skia/source/detail?r=624

[Steve VanDeBogart, 2010-11-09 18:24:01]

Did you miss this?

[agl, 2010-11-09 19:45:19]

I managed to star this one, but I starred so many other ones that it got pushed
under the fold. Sorry about that. As ever, please bug me.


LGTM

http://codereview.appspot.com/2946041/diff/10001/include/utils/SkTextFormatPa...
File include/utils/SkTextFormatParams.h (right):

http://codereview.appspot.com/2946041/diff/10001/include/utils/SkTextFormatPa...
include/utils/SkTextFormatParams.h:23: #define kStdStrikeThru_Offset      
(-SK_Scalar1 * 6 / 21)
I think these magic numbers need some more explanation.

http://codereview.appspot.com/2946041/diff/10001/include/utils/SkTextFormatPa...
include/utils/SkTextFormatParams.h:27: static const SkScalar
kStdFakeBoldInterpKeys[] = {
And these

http://codereview.appspot.com/2946041/diff/10001/src/core/SkScalar.cpp
File src/core/SkScalar.cpp (right):

http://codereview.appspot.com/2946041/diff/10001/src/core/SkScalar.cpp#newcode40
src/core/SkScalar.cpp:40: SkASSERT(rightKey != leftKey);
if (rightKey == leftKey)
  return values[right-1];

http://codereview.appspot.com/2946041/diff/10001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2946041/diff/10001/src/pdf/SkPDFDevice.cpp#newc...
src/pdf/SkPDFDevice.cpp:449: const char* procs[] = {"PDF", "Text", "ImageB",
"ImageC", "ImageI"};
const char procs[][7] (saves the relocation records)

[Steve VanDeBogart, 2010-11-11 00:57:15]

Thanks for the review!

http://codereview.appspot.com/2946041/diff/10001/include/utils/SkTextFormatPa...
File include/utils/SkTextFormatParams.h (right):

http://codereview.appspot.com/2946041/diff/10001/include/utils/SkTextFormatPa...
include/utils/SkTextFormatParams.h:23: #define kStdStrikeThru_Offset      
(-SK_Scalar1 * 6 / 21)
On 2010/11/09 19:45:19, agl wrote:
> I think these magic numbers need some more explanation.

I only moved these values.  However, I added comments describing how they are
used.  I have no ideas how they where derived.

http://codereview.appspot.com/2946041/diff/10001/src/core/SkScalar.cpp
File src/core/SkScalar.cpp (right):

http://codereview.appspot.com/2946041/diff/10001/src/core/SkScalar.cpp#newcode40
src/core/SkScalar.cpp:40: SkASSERT(rightKey != leftKey);
On 2010/11/09 19:45:19, agl wrote:
> if (rightKey == leftKey)
>   return values[right-1];

Looking at this more closely: The while loop currently ensures that this assert
is always true. Removed.

http://codereview.appspot.com/2946041/diff/10001/src/pdf/SkPDFDevice.cpp
File src/pdf/SkPDFDevice.cpp (right):

http://codereview.appspot.com/2946041/diff/10001/src/pdf/SkPDFDevice.cpp#newc...
src/pdf/SkPDFDevice.cpp:449: const char* procs[] = {"PDF", "Text", "ImageB",
"ImageC", "ImageI"};
On 2010/11/09 19:45:19, agl wrote:
> const char procs[][7] (saves the relocation records)

Done.