Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(978)

Issue 2946: Update NumPy API format to support updates that don't break binary compatibility

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years, 8 months ago by stefanv
Modified:
9 years, 4 months ago
Reviewers:
Andrew Straw
Base URL:
http://svn.scipy.org/svn/numpy/trunk/
Visibility:
Public.

Description

The current NumPy API number, stored as NPY_VERSION in the header files, needs to be incremented every time the NumPy C-API changes. The counter tells developers with exactly which revision of the API they are dealing. NumPy does some checking to make sure that it does not run against an old version of the API. Currently, we have no way of distinguishing between changes that break binary compatibility and those that don't. The proposed fix breaks the version number up into two counters -- one that gets increased when binary compatibility is broken, and another when the API is changed without breaking compatibility. Backward compatibility with packages such as Matplotlib is maintained by renaming NPY_VERSION to NPY_BINARY_VERSION.

Patch Set 1 #

Patch Set 2 : Updated with Andrew's suggestions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -5 lines) Patch
numpy/core/code_generators/generate_numpy_api.py View 1 1 chunk +5 lines, -3 lines 0 comments Download
numpy/core/include/numpy/ndarrayobject.h View 1 1 chunk +17 lines, -1 line 0 comments Download
numpy/core/src/multiarraymodule.c View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4
stefanv
15 years, 8 months ago (2008-08-15 23:08:07 UTC) #1
Andrew Straw
A couple of extremely minor nits. http://codereview.appspot.com/2946/diff/1/2 File numpy/core/include/numpy/ndarrayobject.h (right): http://codereview.appspot.com/2946/diff/1/2#newcode43 Line 43: #define NPY_VERSION ...
15 years, 8 months ago (2008-08-16 07:20:55 UTC) #2
stefanv
http://codereview.appspot.com/2946/diff/1/2 File numpy/core/include/numpy/ndarrayobject.h (right): http://codereview.appspot.com/2946/diff/1/2#newcode43 Line 43: #define NPY_VERSION 0x1000000B On 2008/08/16 07:20:56, Andrew Straw ...
15 years, 8 months ago (2008-08-16 07:33:19 UTC) #3
stefanv
15 years, 8 months ago (2008-08-16 07:35:08 UTC) #4
Updated with Andrew's suggestions.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b