Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(995)

Issue 294390043: Move Callback_wrapper class to separate file and simplify

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 12 months ago by pkx166h
Modified:
7 years, 12 months ago
Reviewers:
dak, carl.d.sorensen, Carl
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Move Callback_wrapper class to separate file and simplify Callback_wrapper::make_smob now is only templated on the address of the (static) trampoline function. Moving the trampolining to the actual functions in question makes callbacks quite more versatile and transparent and obviates the previous need for friend declarations due to mixing internals of other classes into the Callback_wrapper definition.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -76 lines) Patch
A + lily/callback.cc View 2 chunks +2 lines, -4 lines 0 comments Download
A lily/include/callback.hh View 1 chunk +70 lines, -0 lines 0 comments Download
M lily/include/listener.hh View 2 chunks +4 lines, -66 lines 0 comments Download
M lily/include/translator.hh View 1 chunk +13 lines, -1 line 0 comments Download
M lily/include/translator.icc View 2 chunks +3 lines, -3 lines 0 comments Download
M lily/listener.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 2
Carl
LGTM. Looks like it is clarifying and simplifying things, and might even help us with ...
7 years, 12 months ago (2016-04-28 14:22:00 UTC) #1
dak
7 years, 12 months ago (2016-04-28 14:36:07 UTC) #2
On 2016/04/28 14:22:00, Carl wrote:
> LGTM.  Looks like it is clarifying and simplifying things, and might even help
> us with Guile2 migration.

Actually, it's mostly preparatory work to pull the Acknowledger structures out
from C++ (and pointer-to-member stuff that has no equal representation in Scheme
engravers) and into Scheme.  Which would allow unifying the data flow of C++ and
Scheme engravers (currently, Scheme engravers acknowledge everything and then
sort it out manually).

I don't see it helping with Guile2.  The main advantage for me is that
Callback_wrapper now only does one thing without meddling in the internals of
other classes.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b