Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(280)

Issue 293190043: 802.11e TXOP (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
7 years, 11 months ago by S. Deronne
Modified:
7 years, 8 months ago
CC:
ns-3-reviews_googlegroups.com
Visibility:
Public.

Description

802.11e TXOP

Patch Set 1 #

Patch Set 2 : add support for EDCA parameter set #

Patch Set 3 : merged with ns-3-dev + add example #

Total comments: 43

Patch Set 4 : handled review comments (to be applied on top of issue 302880043) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1614 lines, -44 lines) Patch
A examples/wireless/80211e-txop.cc View 1 2 3 1 chunk +327 lines, -0 lines 0 comments Download
M examples/wireless/wscript View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M src/wave/model/channel-scheduler.h View 1 4 chunks +6 lines, -6 lines 0 comments Download
M src/wave/model/channel-scheduler.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/wifi/model/ap-wifi-mac.h View 1 2 chunks +7 lines, -0 lines 0 comments Download
M src/wifi/model/ap-wifi-mac.cc View 1 4 chunks +57 lines, -0 lines 0 comments Download
M src/wifi/model/dca-txop.h View 2 chunks +3 lines, -1 line 0 comments Download
M src/wifi/model/dca-txop.cc View 4 chunks +19 lines, -2 lines 0 comments Download
M src/wifi/model/dcf.h View 1 2 3 3 chunks +14 lines, -0 lines 0 comments Download
M src/wifi/model/dcf.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/wifi/model/dcf-manager.h View 3 chunks +14 lines, -0 lines 0 comments Download
M src/wifi/model/dcf-manager.cc View 2 chunks +13 lines, -0 lines 0 comments Download
A src/wifi/model/edca-parameter-set.h View 1 2 3 1 chunk +387 lines, -0 lines 0 comments Download
A src/wifi/model/edca-parameter-set.cc View 1 1 chunk +435 lines, -0 lines 0 comments Download
M src/wifi/model/edca-txop-n.h View 1 2 4 chunks +20 lines, -0 lines 0 comments Download
M src/wifi/model/edca-txop-n.cc View 1 2 10 chunks +137 lines, -8 lines 0 comments Download
M src/wifi/model/mac-low.h View 5 chunks +15 lines, -5 lines 0 comments Download
M src/wifi/model/mac-low.cc View 1 2 3 5 chunks +16 lines, -6 lines 0 comments Download
M src/wifi/model/mgt-headers.h View 1 7 chunks +37 lines, -10 lines 0 comments Download
M src/wifi/model/mgt-headers.cc View 1 8 chunks +29 lines, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/wifi/model/regular-wifi-mac.cc View 1 2 3 3 chunks +5 lines, -3 lines 0 comments Download
M src/wifi/model/sta-wifi-mac.h View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
M src/wifi/model/sta-wifi-mac.cc View 1 2 3 3 chunks +28 lines, -0 lines 0 comments Download
M src/wifi/model/wifi-mac.h View 1 chunk +2 lines, -1 line 0 comments Download
M src/wifi/model/wifi-mac.cc View 1 2 3 2 chunks +20 lines, -1 line 0 comments Download
M src/wifi/wscript View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 24
Tom Henderson
Initial question: we have existing 802.11e per-AC attributes in RegularWifiMac, but this one is in ...
7 years, 11 months ago (2016-04-20 17:15:12 UTC) #1
S. Deronne
On 2016/04/20 17:15:12, Tom Henderson wrote: > Initial question: we have existing 802.11e per-AC attributes ...
7 years, 11 months ago (2016-04-20 19:53:18 UTC) #2
Stefano Avallone
The changes look okay to me, though my knowledge of the wifi code is still ...
7 years, 11 months ago (2016-04-23 21:18:10 UTC) #3
S. Deronne
On 2016/04/23 21:18:10, Stefano Avallone wrote: > The changes look okay to me, though my ...
7 years, 11 months ago (2016-04-24 12:52:08 UTC) #4
S. Deronne
Added a new patch set addressing the suggestion from Stefano.
7 years, 11 months ago (2016-05-01 20:47:57 UTC) #5
Tom Henderson
One final question I have is whether you see an opportunity to create a new ...
7 years, 9 months ago (2016-06-24 23:16:02 UTC) #6
S. Deronne
https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc File examples/wireless/80211e-txop.cc (right): https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc#newcode26 examples/wireless/80211e-txop.cc:26: #include "ns3/ipv4-global-routing-helper.h" On 2016/06/24 23:16:01, Tom Henderson wrote: > ...
7 years, 9 months ago (2016-06-28 21:12:01 UTC) #7
S. Deronne
7 years, 9 months ago (2016-06-29 19:24:48 UTC) #8
S. Deronne
I guess something could be done in EdcaTxopN, but I do not really see the ...
7 years, 9 months ago (2016-06-29 19:26:17 UTC) #9
Tom Henderson
On 2016/06/29 19:26:17, S. Deronne wrote: > I guess something could be done in EdcaTxopN, ...
7 years, 9 months ago (2016-06-29 19:41:04 UTC) #10
Tom Henderson
> https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc#newcode274 > examples/wireless/80211e-txop.cc:274: myClientC.SetAttribute ("AccessClass", > UintegerValue (4)); //AC_VI > On 2016/06/24 23:16:01, Tom ...
7 years, 9 months ago (2016-06-29 19:58:34 UTC) #11
Stefano Avallone
On 2016/06/29 19:58:34, Tom Henderson wrote: > > > VI is value 2, not 4 ...
7 years, 9 months ago (2016-06-29 21:41:04 UTC) #12
Stefano Avallone
https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc File examples/wireless/80211e-txop.cc (right): https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc#newcode29 examples/wireless/80211e-txop.cc:29: // This is an example that illustrates 802.11 QoS ...
7 years, 9 months ago (2016-06-29 21:42:35 UTC) #13
Stefano Avallone
> Well, the code should explain these things better... Tomorrow I should be able > ...
7 years, 9 months ago (2016-06-30 17:49:26 UTC) #14
S. Deronne
https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc File examples/wireless/80211e-txop.cc (right): https://codereview.appspot.com/293190043/diff/40001/examples/wireless/80211e-txop.cc#newcode29 examples/wireless/80211e-txop.cc:29: // This is an example that illustrates 802.11 QoS ...
7 years, 9 months ago (2016-07-01 18:27:07 UTC) #15
S. Deronne
Stefano, when would you be able to provide a wifi test case?
7 years, 9 months ago (2016-07-01 18:28:41 UTC) #16
Stefano Avallone
On 2016/07/01 18:28:41, S. Deronne wrote: > Stefano, when would you be able to provide ...
7 years, 9 months ago (2016-07-01 20:00:47 UTC) #17
S. Deronne
Stefano, where do those values come from? AddTestCase (new WifiAcMappingTest (0xb8, 2), TestCase::QUICK); // EF ...
7 years, 9 months ago (2016-07-02 08:57:25 UTC) #18
S. Deronne
On 2016/07/02 08:57:25, S. Deronne wrote: > Stefano, where do those values come from? > ...
7 years, 9 months ago (2016-07-02 09:09:14 UTC) #19
Stefano Avallone
On 2016/07/02 09:09:14, S. Deronne wrote: > On 2016/07/02 08:57:25, S. Deronne wrote: > > ...
7 years, 9 months ago (2016-07-02 10:49:02 UTC) #20
Tom Henderson
On 2016/07/02 09:09:14, S. Deronne wrote: > On 2016/07/02 08:57:25, S. Deronne wrote: > > ...
7 years, 9 months ago (2016-07-02 15:37:02 UTC) #21
S. Deronne
Final patch set available, still need to include trace source (non blocking for delivery).
7 years, 8 months ago (2016-07-05 21:02:13 UTC) #22
S. Deronne
Pushed!
7 years, 8 months ago (2016-07-14 19:04:02 UTC) #23
S. Deronne
7 years, 8 months ago (2016-07-14 19:04:14 UTC) #24

          
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b