Issue 291500043: Bug 1253161 - Remove unused or unuseful macros in libssl

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 291500043: Bug 1253161 - Remove unused or unuseful macros in libssl (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years ago by mt

Modified:
7 years, 8 months ago

Reviewers:
ttaubert

Visibility:
Public.

More Reviews

Description

These macros are not used much and were just lazy programming

Patch Set 2 : Use send alert direct for RSA client key failure #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -32 lines)			Patch
M	lib/ssl/ssl3con.c	View	1	4 chunks	+7 lines, -5 lines	0 comments	Download
M	lib/ssl/sslcon.c	View		1 chunk	+0 lines, -3 lines	0 comments	Download
M	lib/ssl/sslimpl.h	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	lib/ssl/sslsecur.c	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	lib/ssl/sslsnce.c	View		7 chunks	+7 lines, -11 lines	0 comments	Download
M	lib/ssl/sslsock.c	View		2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4

Expand All Messages | Collapse All Messages

ttaubert

https://codereview.appspot.com/291500043/diff/1/lib/ssl/ssl3con.c File lib/ssl/ssl3con.c (right): https://codereview.appspot.com/291500043/diff/1/lib/ssl/ssl3con.c#newcode10625 lib/ssl/ssl3con.c:10625: return SECFailure; /* error code set */ Should we ...

8 years ago (2016-04-26 09:40:26 UTC) #2

8 years ago (2016-04-26 11:18:48 UTC) #4

https://codereview.appspot.com/291500043/diff/1/lib/ssl/ssl3con.c
File lib/ssl/ssl3con.c (right):

https://codereview.appspot.com/291500043/diff/1/lib/ssl/ssl3con.c#newcode10625
lib/ssl/ssl3con.c:10625: return SECFailure; /* error code set */
On 2016/04/26 09:40:26, ttaubert wrote:
> Should we just use |SSL3_SendAlert(ss, alert_fatal, handshake_failure)| so
that
> |ssl3_HandshakeFailure| doesn't override the error set by
> |ssl3_HandleRSAClientKeyExchange|?

Yeah, though it means saving the error code either way unfortunately. 
SSL3_SendAlert might fail and pollute things.

Expand All Messages | Collapse All Messages