output-svg.scm: better defaults for font-family

output-svg.scm: better defaults for font-family

if the user has not set the font, use a
meaningful svg default ('serif' 'sans-serif'
or 'monospace') for the font-family property

[pwm, 2016-02-19 03:34:28]

Please review. See the discussion in this thread on the bug list:

http://lists.gnu.org/archive/html/bug-lilypond/2016-02/msg00079.html

Thanks,
-Paul

[Carl, 2016-02-19 04:18:19]

LGTM.

I still have concerns about ugly files showing up when somebody passes along a
.svg, but the appropriate fonts aren't installed.   But I can't think of a
reasonable way to handle it, and I think it's better to have an ugly sans-serif
font when sans is asked for than to have a beautiful serif font.

All in all, I think this is a nice solution (with a surprisingly minor change
set).

Carl

[lemzwerg, 2016-02-19 06:38:18]

LGTM

[trueroad, 2016-02-20 08:20:12]

LGTM

But here is another method.

--- a/scm/font.scm	2015-12-07 00:27:32.000000000 +0900
+++ b/scm/font.scm	2016-02-20 17:15:16.479543100 +0900
@@ -257,9 +257,12 @@
 (define*-public (set-global-fonts #:key 
   (music "emmentaler")
   (brace "emmentaler")
-  (roman "LilyPond Serif")
-  (sans "LilyPond Sans Serif")
-  (typewriter "LilyPond Monospace")
+  (roman (if (eq? (ly:get-option 'backend) 'svg)
+	     "serif" "LilyPond Serif"))
+  (sans (if (eq? (ly:get-option 'backend) 'svg)
+	    "sans-serif" "LilyPond Sans Serif"))
+  (typewriter (if (eq? (ly:get-option 'backend) 'svg)
+		  "monospace" "LilyPond Monospace"))
   (factor 1))
   (let ((n (make-font-tree-node 'font-encoding 'fetaMusic)))
     (add-music-fonts n 'feta music brace feta-design-size-mapping factor)
@@ -278,9 +281,9 @@
 
 (define-public (make-default-fonts-tree factor)
   (make-pango-font-tree
-   "LilyPond Serif"
-   "LilyPond Sans Serif"
-   "LilyPond Monospace"
+   (if (eq? (ly:get-option 'backend) 'svg) "serif" "LilyPond Serif")
+   (if (eq? (ly:get-option 'backend) 'svg) "sans-serif" "LilyPond Sans Serif")
+   (if (eq? (ly:get-option 'backend) 'svg) "monospace" "LilyPond Monospace")
    factor))
 
 (define-public all-text-font-encodings

[pwm, 2016-02-20 17:39:23]

Set svg defaults in font.scm instead and add doc edits

[pwm, 2016-02-20 17:43:40]

On 2016/02/20 08:20:12, trueroad wrote:
> LGTM
> 
> But here is another method.

Thank you, this is better, and I've used it in patch set 2.  
Patch set 2 also includes some edits to the docs (as a separate commit).

-Paul

[pwm, 2016-02-20 17:51:55]

fix whitespace in font.scm

[pwm, 2016-02-20 17:55:29]

another whitespace fix (missed one space)

[pwm, 2016-02-20 18:12:10]

minor doc edit