Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(151)

Issue 290490043: Let ',' separate symbol lists like '.' does

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by dak
Modified:
8 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Let ',' separate symbol lists like '.' does While the dotted list syntax is natural for hierarchical paths like for \override and \revert, it is less natural in cases that may now be written as \keepWithTag violin,flute,oboe { c''' }

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -1 line) Patch
M lily/parser.yy View 6 chunks +23 lines, -1 line 0 comments Download

Messages

Total messages: 10
lemzwerg
Nice idea, thank! LGTM.
8 years, 1 month ago (2016-03-08 16:45:10 UTC) #1
lemzwerg
Nice idea, thanks! LGTM.
8 years, 1 month ago (2016-03-08 16:45:20 UTC) #2
simon.albrecht
I also like the idea. Should this get a regtest? Best, Simon
8 years, 1 month ago (2016-03-08 17:52:09 UTC) #3
dak
On 2016/03/08 17:52:09, simon.albrecht wrote: > I also like the idea. > Should this get ...
8 years, 1 month ago (2016-03-08 18:17:58 UTC) #4
dan_faithful.be
On Mar 8, 2016, at 13:17 , dak@gnu.org wrote: > > Description: > Let ',' ...
8 years, 1 month ago (2016-03-08 22:42:55 UTC) #5
dak
On 2016/03/08 22:42:55, dan_faithful.be wrote: > On Mar 8, 2016, at 13:17 , mailto:dak@gnu.org wrote: ...
8 years, 1 month ago (2016-03-08 22:55:51 UTC) #6
thomasmorley651
On 2016/03/08 22:55:51, dak wrote: > On 2016/03/08 22:42:55, dan_faithful.be wrote: > > On Mar ...
8 years, 1 month ago (2016-03-08 23:28:37 UTC) #7
dan_faithful.be
On Mar 8, 2016, at 17:55 , dak@gnu.org wrote: > >> So it would be ...
8 years, 1 month ago (2016-03-09 02:11:57 UTC) #8
dak
On 2016/03/08 23:28:37, thomasmorley651 wrote: > > I firstly had some concerns about problems arising ...
8 years, 1 month ago (2016-03-09 09:10:42 UTC) #9
thomasmorley651
8 years, 1 month ago (2016-03-09 22:50:56 UTC) #10
On 2016/03/09 09:10:42, dak wrote:
> On 2016/03/08 23:28:37, thomasmorley651 wrote:
> 
> > 
> > I firstly had some concerns about problems arising from people being tempted
> to
> > write additional spaces after the comma, though with:
> > 
> > blub = #(define-void-function (arg)(list?) (write (map symbol->string arg)))
> > \blub foo . bar . buzz
> > 
> > I noticed no problem. Hence I expect no problems with commas as well.
> 
> Unfortunately, there is in lyricsmode.  As opposed to non-quoted stuff
starting
> with a '.', ',' is not special.  I considered changing that, but while that
> would have allowed \blub foo , bar , buzz or even \blub foo ,bar ,buzz it
would
> not have helped with the much more important \blub foo, bar, buzz so it is
sort
> of pointless.  And we definitely do not want to split foo, into two tokens in
> lyricsmode.  So in lyricsmode, we'd more or less be stuck with foo,bar,buzz .

ok

> So all-in-all, it is a bit of a so-so improvement.  Its main motivation for me
> really is not to have to use '.' for grouping numbers since it is already used
> inside of numbers.  And it does make tag lists look nicer.  And lyricsmode is
> not really overcrowded with music functions so this will likely not become an
> issue all too often.

agreed
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b