Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4406)

Issue 290270043: Doc: NR - Issue 4761 - changing-defaults.itely: Various improvements (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by pkx166h
Modified:
7 years, 1 month ago
Reviewers:
fedelogy, Jean-Charles
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Doc: NR - Issue 4761 - changing-defaults.itely: Various improvements A variety of nitpicks and improvements reported by Federico Bruni Some spelling corrections and typos fixed. The section on \set vs. \override has been edited in an attmpt to simplify the explanation for the reader. Fixed a couple of TODOs. Added a @c that references an open issue to improve the example for pure/unpure containers as the example no longer illustrates what it used to as of LP 2.17.x +

Patch Set 1 #

Total comments: 4

Patch Set 2 : With Jean-Charles M and Federico B's considerations and corrections addressed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -90 lines) Patch
M Documentation/notation/changing-defaults.itely View 1 13 chunks +107 lines, -90 lines 0 comments Download

Messages

Total messages: 5
fedelogy
just a doubt about the use of @code in one sentence https://codereview.appspot.com/290270043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): ...
8 years, 2 months ago (2016-02-20 09:13:44 UTC) #1
Jean-Charles
Otherwise LGTM https://codereview.appspot.com/290270043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/290270043/diff/1/Documentation/notation/changing-defaults.itely#newcode2446 Documentation/notation/changing-defaults.itely:2446: time of the context's creation, properties are ...
8 years, 2 months ago (2016-02-20 10:58:53 UTC) #2
pkx166h
With Jean-Charles M and Federico B's considerations and corrections addressed.
8 years, 2 months ago (2016-02-21 11:05:53 UTC) #3
pkx166h
Thanks for the review. https://codereview.appspot.com/290270043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/290270043/diff/1/Documentation/notation/changing-defaults.itely#newcode2446 Documentation/notation/changing-defaults.itely:2446: time of the context's creation, ...
8 years, 2 months ago (2016-02-21 11:06:37 UTC) #4
pkx166h
7 years, 1 month ago (2017-03-12 18:33:38 UTC) #5
author James Lowe pkx166h@gmail.com
Fri, 19 Feb 2016 11:54:25 +0000 (11:54 +0000)
committer James Lowe pkx166h@gmail.com
Sun, 28 Feb 2016 09:18:03 +0000 (09:18 +0000)
commit 4299c96f609f79426a181ffed107d17fa6e1fdbd
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b