Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(236)

Issue 288910043: Add ly:one-page-breaking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by pwm
Modified:
7 years, 5 months ago
Reviewers:
ul, pkx166h, simon.albrecht
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add ly:one-page-breaking includes regtest, doc entry, changes entry

Patch Set 1 #

Total comments: 4

Patch Set 2 : Fix a few whitespace typos. #

Patch Set 3 : update docs with ly:one-line-auto-height-breaking #

Patch Set 4 : Update patches to apply to current master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+241 lines, -15 lines) Patch
M Documentation/changes.tely View 1 2 3 1 chunk +6 lines, -5 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 2 3 4 chunks +27 lines, -3 lines 0 comments Download
A input/regression/one-page-breaking.ly View 1 2 3 1 chunk +14 lines, -0 lines 0 comments Download
A + lily/include/one-page-breaking.hh View 2 chunks +9 lines, -7 lines 0 comments Download
A lily/one-page-breaking.cc View 1 1 chunk +174 lines, -0 lines 0 comments Download
M lily/page-breaking-scheme.cc View 1 2 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 10
pwm
Fix a few whitespace typos.
8 years, 3 months ago (2016-01-24 18:28:02 UTC) #1
pwm
Please review, thanks, -Paul
8 years, 3 months ago (2016-01-24 18:30:00 UTC) #2
simon.albrecht
I can’t say anything on the C++ part. There’s some trailing whitespace in the regtest ...
8 years, 3 months ago (2016-01-24 18:32:37 UTC) #3
simon.albrecht
https://codereview.appspot.com/288910043/diff/1/Documentation/notation/spacing.itely File Documentation/notation/spacing.itely (right): https://codereview.appspot.com/288910043/diff/1/Documentation/notation/spacing.itely#newcode895 Documentation/notation/spacing.itely:895: @code{ly:one-page-breaking}, @code{ly:one-line-breaking} and On 2016/01/24 18:32:37, simon.albrecht wrote: > ...
8 years, 3 months ago (2016-01-24 20:53:39 UTC) #4
pwm
update docs with ly:one-line-auto-height-breaking
8 years, 3 months ago (2016-01-27 04:30:25 UTC) #5
pwm
Now that ly:one-line-auto-height is in master, this patch set updates the docs so it and ...
8 years, 3 months ago (2016-01-27 04:34:46 UTC) #6
ul_openlilylib.org
Am 27. Januar 2016 05:34:46 MEZ, schrieb paulwmorris@gmail.com: >Now that ly:one-line-auto-height is in master, this ...
8 years, 3 months ago (2016-01-27 05:55:03 UTC) #7
pkx166h
author Paul Morris <paulwmorris@gmail.com> Wed, 3 Feb 2016 16:37:46 +0000 (16:37 +0000) committer James Lowe ...
8 years, 2 months ago (2016-02-03 16:40:45 UTC) #8
pkx166h
This patch unfortunately broke staging. See thread: http://lists.gnu.org/archive/html/lilypond-devel/2016-02/msg00005.html For now this has been set back ...
8 years, 2 months ago (2016-02-04 06:15:31 UTC) #9
pwm
7 years, 5 months ago (2016-11-14 18:27:43 UTC) #10
Update patches to apply to current master
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b