Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(14)

Delta Between Two Patch Sets: src/com/ziclix/python/sql/connect/Connectx.java

Issue 2888: __findattr__ refactor (Closed) SVN Base: https://jython.svn.sourceforge.net/svnroot/jython/branches/asm
Left Patch Set: Created 1 year, 2 months ago
Right Patch Set: This is the actually commited patch (on r5155), in case you have more comments Created 1 year, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * Jython Database Specification API 2.0 2 * Jython Database Specification API 2.0
3 * 3 *
4 * $Id$ 4 * $Id$
5 * 5 *
6 * Copyright (c) 2001 brian zimmer <bzimmer@ziclix.com> 6 * Copyright (c) 2001 brian zimmer <bzimmer@ziclix.com>
7 * 7 *
8 */ 8 */
9 package com.ziclix.python.sql.connect; 9 package com.ziclix.python.sql.connect;
10 10
(...skipping 25 matching lines...) Expand all
36 36
37 private final String SET = "set"; 37 private final String SET = "set";
38 private final PyString doc = new PyString("establish a connection through a javax.sql.DataSource or javax.sql.ConnectionPooledDataSource"); 38 private final PyString doc = new PyString("establish a connection through a javax.sql.DataSource or javax.sql.ConnectionPooledDataSource");
39 39
40 /** 40 /**
41 * Constructor Connectx 41 * Constructor Connectx
42 */ 42 */
43 public Connectx() { 43 public Connectx() {
44 } 44 }
45 45
46 /**
47 * Method __findattr__
Nicholas Riley 2008/08/11 04:45:50 Comment needs updating.
Leo Soto M. 2008/08/11 22:58:47 On 2008/08/11 04:45:50, Nicholas Riley wrote: > Co
48 *
49 * @param String name
50 * @return PyObject
51 */
52 public PyObject __findattr_ex__(String name) { 46 public PyObject __findattr_ex__(String name) {
53
54 if ("__doc__".equals(name)) { 47 if ("__doc__".equals(name)) {
55 return doc; 48 return doc;
56 } 49 }
57
58 return super.__findattr_ex__(name); 50 return super.__findattr_ex__(name);
59 } 51 }
60 52
61 /** 53 /**
62 * Construct a javax.sql.DataSource or javax.sql.ConnectionPooledDataSource 54 * Construct a javax.sql.DataSource or javax.sql.ConnectionPooledDataSource
63 */ 55 */
64 public PyObject __call__(PyObject[] args, String[] keywords) { 56 public PyObject __call__(PyObject[] args, String[] keywords) {
65 57
66 Connection c = null; 58 Connection c = null;
67 PyConnection pc = null; 59 PyConnection pc = null;
(...skipping 123 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 } 183 }
192 184
193 if ((primitive != null) && primitive.isPrimitive()) { 185 if ((primitive != null) && primitive.isPrimitive()) {
194 return getMethod(srcClass, methodName, primitive); 186 return getMethod(srcClass, methodName, primitive);
195 } 187 }
196 } 188 }
197 189
198 return method; 190 return method;
199 } 191 }
200 } 192 }
LEFTRIGHT

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld r483