__findattr__ refactor

This should fix:

http://bugs.jython.org/issue1041
http://bugs.jython.org/issue1095

Based on Samuele's suggestion on
http://www.nabble.com/Re%3A-On-__findattr__%2C-__getattr__-and-__getattribute...

[fwierzbicki]

http://codereview.appspot.com/2888/diff/1/76
File src/templates/object.derived (right):

http://codereview.appspot.com/2888/diff/1/76#newcode317
Line 317: return getattribute.__get__(this,self_type).__call__(py_name =
PyString.fromInterned(name));
Nitpicking here, but I never like when an assignment is used as an argument, I'd
be happier if py_name = PyString.fromInterned(name) was a separate line. 
Otherwise I think all of this looks pretty sound.  Also feel free to ignore
since this fits the style of object.derived etc anyway :)

[Nicholas Riley]

few minor comments

http://codereview.appspot.com/2888/diff/1/71
File src/com/ziclix/python/sql/connect/Connect.java (right):

http://codereview.appspot.com/2888/diff/1/71#newcode36
Line 36: * Method __findattr__
Comment needs updating.

http://codereview.appspot.com/2888/diff/1/70
File src/com/ziclix/python/sql/connect/Connectx.java (right):

http://codereview.appspot.com/2888/diff/1/70#newcode47
Line 47: * Method __findattr__
Comment needs updating.

http://codereview.appspot.com/2888/diff/1/76
File src/templates/object.derived (right):

http://codereview.appspot.com/2888/diff/1/76#newcode320
Line 320: //      __getattribute__.
emit a warning? is this a backwards-incompatible change?

http://codereview.appspot.com/2888/diff/1/76#newcode324
Line 324: //      '__getattribute__' lookup each time.
link to a bug, and move to the 'if' branch'... it's odd that it's not with the
code it's referring to

http://codereview.appspot.com/2888/diff/1/76#newcode344
Line 344: } else {
the 'else' isn't necessary

[Leo Soto M.]

http://codereview.appspot.com/2888/diff/1/71
File src/com/ziclix/python/sql/connect/Connect.java (right):

http://codereview.appspot.com/2888/diff/1/71#newcode36
Line 36: * Method __findattr__
On 2008/08/11 04:45:50, Nicholas Riley wrote:
> Comment needs updating.

Actually, the comment is not giving any information at all  so I'm going to
remove it.

http://codereview.appspot.com/2888/diff/1/70
File src/com/ziclix/python/sql/connect/Connectx.java (right):

http://codereview.appspot.com/2888/diff/1/70#newcode47
Line 47: * Method __findattr__
On 2008/08/11 04:45:50, Nicholas Riley wrote:
> Comment needs updating.

Same as above

[Leo Soto M.]

Suggestions applied

[Leo Soto M.]

This is the actually commited patch (on r5155), in case you have more comments