http://codereview.appspot.com/2888/diff/1/76 File src/templates/object.derived (right): http://codereview.appspot.com/2888/diff/1/76#newcode317 Line 317: return getattribute.__get__(this,self_type).__call__(py_name = PyString.fromInterned(name)); Nitpicking here, but I ...
1 year, 2 months ago
http://codereview.appspot.com/2888/diff/1/76
File src/templates/object.derived (right):
http://codereview.appspot.com/2888/diff/1/76#newcode317
Line 317: return getattribute.__get__(this,self_type).__call__(py_name =
PyString.fromInterned(name));
Nitpicking here, but I never like when an assignment is used as an argument, I'd
be happier if py_name = PyString.fromInterned(name) was a separate line.
Otherwise I think all of this looks pretty sound. Also feel free to ignore
since this fits the style of object.derived etc anyway :)
Issue 2888: __findattr__ refactor
(Closed)
Created 1 year, 2 months ago by Leo Soto M.
Modified 3 months, 1 week ago
Reviewers: fwierzbicki, Nicholas Riley
SVN Base: https://jython.svn.sourceforge.net/svnroot/jython/branches/asm
Comments: 8