Issue 288700043: Make chord-naming robust against unsetting majorSevenSymbol

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 288700043: Make chord-naming robust against unsetting majorSevenSymbol (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 1 month ago by thomasmorley651

Modified:
7 years, 1 month ago

Reviewers:
carl.d.sorensen, Carl

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Make chord-naming robust against unsetting majorSevenSymbol This will likely be changed anyway as soon as rewriting chord-names is seriously tackled. At least it might be a reminder to take care of the possibility a user wants to unset majorSevenSymbol.

Patch Set 1 #

Patch Set 2 : Regtest amended #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+12 lines, -5 lines)			Patch
	M	input/regression/chord-name-major7.ly	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	M	scm/chord-ignatzek-names.scm	View		1 chunk	+6 lines, -4 lines	0 comments	Download

Messages

Total messages: 3

Expand All Messages | Collapse All Messages

Carl

LGTM. I don't know if this will become obsolete or not with the GSOC chord ...

8 years, 1 month ago (2016-03-22 18:08:27 UTC) #2

Regtest amended

Expand All Messages | Collapse All Messages