Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(755)

Issue 286680043: Require path separators in assignments/overrides

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 1 month ago by dak
Modified:
8 years, 1 month ago
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Require path separators in assignments/overrides Historical assignments/overrides like Variable #'x #'y = 7 or \override Glissando.bound-details #'left #'Y = #3 without dots between the various path components do not match the syntax of \revert and music functions or other uses. Disallow the non-separation by '.' or ',' of such path components.

Patch Set 1 #

Patch Set 2 : Fixed the oversight in the snippets. Hopefully the only one. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -29 lines) Patch
M Documentation/snippets/arranging-separate-lyrics-on-a-single-line.ly View 1 3 chunks +9 lines, -9 lines 0 comments Download
A + Documentation/snippets/new/arranging-separate-lyrics-on-a-single-line.ly View 1 2 chunks +3 lines, -11 lines 0 comments Download
M lily/parser.yy View 3 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 4
thomasmorley651
Can't review parser-code, but from description: This is the logical consequence of your previous work. ...
8 years, 1 month ago (2016-03-13 23:28:34 UTC) #1
lemzwerg
LGTM. I assume that convert-ly already does the right thing...
8 years, 1 month ago (2016-03-14 06:40:27 UTC) #2
dak
On 2016/03/14 06:40:27, lemzwerg wrote: > LGTM. > > I assume that convert-ly already does ...
8 years, 1 month ago (2016-03-14 07:06:11 UTC) #3
dak
8 years, 1 month ago (2016-03-14 21:12:04 UTC) #4
Fixed the oversight in the snippets.  Hopefully the only one.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b