Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1216)

Issue 284240043: Add ly:one-line-auto-height-breaking (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 3 months ago by pwm
Modified:
8 years, 2 months ago
Reviewers:
git, paul, lemzwerg
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add ly:one-line-auto-height-breaking Includes 4 commits: Changes entry for ly:one-line-auto-height-breaking Doc: NR 4.3.2 add ly:one-line-auto-height-breaking Includes a few related edits to NR 4.3.2 mainly for ly:one-line-breaking Add regtest for ly:one-line-auto-height-breaking Add ly:one-line-auto-height-breaking

Patch Set 1 #

Total comments: 2

Patch Set 2 : a few documentation edits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -33 lines) Patch
M Documentation/changes.tely View 1 chunk +7 lines, -0 lines 0 comments Download
M Documentation/notation/spacing.itely View 1 4 chunks +28 lines, -10 lines 0 comments Download
A input/regression/one-line-auto-height-breaking.ly View 1 1 chunk +11 lines, -0 lines 0 comments Download
A + lily/include/one-line-auto-height-breaking.hh View 1 chunk +6 lines, -6 lines 0 comments Download
A + lily/one-line-auto-height-breaking.cc View 1 4 chunks +22 lines, -11 lines 0 comments Download
M lily/one-line-page-breaking.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M lily/page-breaking-scheme.cc View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 6
pwm
Please review, thanks. -Paul
8 years, 3 months ago (2016-01-14 05:27:19 UTC) #1
lemzwerg
LGTM
8 years, 3 months ago (2016-01-14 06:14:51 UTC) #2
git
This is a great enhancement. I commented on one typo, but I saw two issues ...
8 years, 3 months ago (2016-01-18 12:43:54 UTC) #3
paul_paulwmorris.com
> On Jan 18, 2016, at 7:43 AM, git@ursliska.de wrote: > > This is a ...
8 years, 3 months ago (2016-01-18 15:17:46 UTC) #4
pwm
a few documentation edits
8 years, 3 months ago (2016-01-19 02:57:13 UTC) #5
pwm
8 years, 3 months ago (2016-01-19 03:43:00 UTC) #6
A few doc edits. -Paul

https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacin...
File Documentation/notation/spacing.itely (right):

https://codereview.appspot.com/284240043/diff/1/Documentation/notation/spacin...
Documentation/notation/spacing.itely:895: @code{ly:one-line-breaking},
@code{ly:one-line-auto-height-page-breaking},
On 2016/01/18 12:43:54, git wrote:
> I think this should read "ly:one-line-auto-height-breaking"

Done.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b