Issue 284000043: Improve note-by-number to deal better with flag-styles

Issue 284000043: Improve note-by-number to deal better with flag-styles (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by thomasmorley651

Modified:
8 years, 3 months ago

Reviewers:
simon.albrecht, lemzwerg

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Improve note-by-number to deal better with flag-styles - Per default every ancient note-head will get a mensural-style-flag. - overriding flag-style will now always work with supported styles: default, straight- and flat-flags and (neo-)mensural-flags

Patch Set 1 #

Patch Set 2 : corrects version in regtest #

Total comments: 1

Patch Set 3 : Simon's comment #

Total comments: 2

Patch Set 4 : Werners comment #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+38 lines, -13 lines)			Patch
	M	input/regression/markup-note-styles.ly	View	1	4 chunks	+15 lines, -3 lines	0 comments	Download
	M	scm/define-markup-commands.scm	View	1 2 3	5 chunks	+23 lines, -10 lines	0 comments	Download

Messages

Total messages: 8

Expand All Messages | Collapse All Messages

simon.albrecht

LGTM, except for one doc nitpick. https://codereview.appspot.com/284000043/diff/20001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/284000043/diff/20001/scm/define-markup-commands.scm#newcode3547 scm/define-markup-commands.scm:3547: mensural-style-flags. All note-heads ...

8 years, 4 months ago (2015-12-27 22:22:56 UTC) #3

thomasmorley651

On 2015/12/27 22:22:56, simon.albrecht wrote: > LGTM, except for one doc nitpick. > > https://codereview.appspot.com/284000043/diff/20001/scm/define-markup-commands.scm ...

8 years, 4 months ago (2015-12-27 23:22:21 UTC) #5

lemzwerg

LGTM https://codereview.appspot.com/284000043/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/284000043/diff/40001/scm/define-markup-commands.scm#newcode3550 scm/define-markup-commands.scm:3550: @code{neomensural}. The latter two flag-style will both result ...

8 years, 4 months ago (2015-12-28 03:33:03 UTC) #6

thomasmorley651

8 years, 4 months ago (2015-12-28 21:17:53 UTC) #8

https://codereview.appspot.com/284000043/diff/40001/scm/define-markup-command...
File scm/define-markup-commands.scm (right):

https://codereview.appspot.com/284000043/diff/40001/scm/define-markup-command...
scm/define-markup-commands.scm:3550: @code{neomensural}.  The latter two
flag-style will both result in
On 2015/12/28 03:33:03, lemzwerg wrote:
> s/flag-style/flag-styles/

Done.

Expand All Messages | Collapse All Messages