Fixes for 64-bit

Unit tests fail in 64-bit Perl.

Here's a patch to get the unit tests working in 64-bit Perl.  It includes various fixes to Encode.pm and Decode.pm, and I moved the BI() function (for portably initializing big integers in 64 or 32 bit Perl) from the test library (perl/t/lib/Test/Protobuf.pm) to Protobuf::Types.  I use BI() to initialize 64-bit default values in the generated code, which fixes a TODO item.  In theory one could argue that BI() should also be used for enum values, or even field numbers (though the latter is really silly!).

Note that I've tested this in both 32-bit and 64-bit environments, but only little-endian.

[jleader, 2008-08-08 01:03:28]

Issue created.

[jleader, 2008-08-08 18:07:16]

Revised patches to fix style issues in Decoder.pm, Encoder.pm, and Types.pm

[GvR, 2008-08-08 21:47:23]

Excuse me for butting in, but I noticed that this issue is generating errors
when you try to view the side-by-side diffs. I believe that's because of your
SVN Base setting.  Try changing that to
http://protobuf-perl.googlecode.com/svn/trunk/ (i.e. append /trunk/).

[jleader, 2008-08-11 17:08:24]

Thanks, I've fixed the SVN Base.  Should the entry in the Repositories be
changed as well?  At one point when I was trying to set up the repository and
submit this issue, I was seeing a url ending with .../svn/trunk/trunk, so now
I'm a little paranoid about breaking something.

[GvR, 2008-08-11 17:19:49]

On 2008/08/11 17:08:24, jleader wrote:
> Thanks, I've fixed the SVN Base.  Should the entry in the Repositories be
> changed as well?  At one point when I was trying to set up the repository and
> submit this issue, I was seeing a url ending with .../svn/trunk/trunk, so now
> I'm a little paranoid about breaking something.

I don't know where those trunk/trunk/ entries come from; I now exclusively use
the upload.py script, and I recommend you do the same.

PS. Sorry for the site outage earlier today.  I screwed up with an upgrade and
forgot to test things. :-(

[bradfitz2, 2008-08-14 17:08:58]

http://codereview.appspot.com/2832/diff/15/23
File perl/lib/Protobuf/Decoder.pm (right):

http://codereview.appspot.com/2832/diff/15/23#newcode36
Line 36: else {
} else {

http://codereview.appspot.com/2832/diff/15/23#newcode62
Line 62: else {
} else {

http://codereview.appspot.com/2832/diff/15/23#newcode132
Line 132: elsif (HAS_QUADS && ($int & $sign_bit_64)) {
} elsif (...) {

http://codereview.appspot.com/2832/diff/15/23#newcode153
Line 153: elsif (HAS_QUADS && ($int & $sign_bit_64)) {
} elsif (...) {

http://codereview.appspot.com/2832/diff/15/24
File perl/lib/Protobuf/Encoder.pm (right):

http://codereview.appspot.com/2832/diff/15/24#newcode186
Line 186: else {
} else {

http://codereview.appspot.com/2832/diff/15/22
File perl/lib/Protobuf/Types.pm (right):

http://codereview.appspot.com/2832/diff/15/22#newcode166
Line 166: return 0+$v if $v =~ /^-?\d*$/;
\d+

Otherwise this matches the empty string and also the string "-"

http://codereview.appspot.com/2832/diff/15/22#newcode167
Line 167: if ($v =~ /^0x/) {
you should match that it's 16 hex digits.  (or no more than 16 hex digits, if
you're prepared for that below)

[GvR, 2008-08-14 17:26:16]

(removing myself from the reviewers list)

[jleader, 2008-08-14 20:04:21]

http://codereview.appspot.com/2832/diff/15/23
File perl/lib/Protobuf/Decoder.pm (right):

http://codereview.appspot.com/2832/diff/15/23#newcode36
Line 36: else {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> } else {

Done.

http://codereview.appspot.com/2832/diff/15/23#newcode62
Line 62: else {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> } else {

Done.

http://codereview.appspot.com/2832/diff/15/23#newcode132
Line 132: elsif (HAS_QUADS && ($int & $sign_bit_64)) {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> } elsif (...) {

Done.

http://codereview.appspot.com/2832/diff/15/23#newcode153
Line 153: elsif (HAS_QUADS && ($int & $sign_bit_64)) {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> } elsif (...) {

Done.

http://codereview.appspot.com/2832/diff/15/24
File perl/lib/Protobuf/Encoder.pm (right):

http://codereview.appspot.com/2832/diff/15/24#newcode186
Line 186: else {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> } else {

Done.

http://codereview.appspot.com/2832/diff/15/22
File perl/lib/Protobuf/Types.pm (right):

http://codereview.appspot.com/2832/diff/15/22#newcode166
Line 166: return 0+$v if $v =~ /^-?\d*$/;
On 2008/08/14 17:08:58, bradfitz2 wrote:
> \d+
> 
> Otherwise this matches the empty string and also the string "-"

Done.

http://codereview.appspot.com/2832/diff/15/22#newcode167
Line 167: if ($v =~ /^0x/) {
On 2008/08/14 17:08:58, bradfitz2 wrote:
> you should match that it's 16 hex digits.  (or no more than 16 hex digits, if
> you're prepared for that below)

Done.

[jleader, 2008-08-14 20:05:39]

Replaces patch set 2, with Brad's suggested changes