Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(338)

Issue 283050043: Add RemoveAllEmptyStaves command (was: Add RemoveEmptyStavesAll command)

Can't Edit
Can't Publish+Mail
Start Review
Created:
8 years, 2 months ago by simon.albrecht
Modified:
8 years, 2 months ago
Reviewers:
dak, Jean-Charles, t.daniels
CC:
lilypond-devel_gnu.org
Visibility:
Public.

Description

Add RemoveEmptyStavesAll command It has been noted several times that we should have a companion for RemoveEmptyStaves to also set remove-first to ##t. I’ve made an attempt at providing it – please review. A doc snippet, removing-the-first-empty-line.ly, has become obsolete with these changes. Should I do something about that? Contains commits: Add missing word in changes.tely Add changes entry for RemoveEmptyStavesAll Use RemoveEmptyStavesAll for ossia example in NR Document RemoveEmptyStavesAll This rewrites documentation for RemoveEmptyStaves and adds information on the newly added RemoveEmptyStavesAll. Add RemoveEmptyStavesAll command Introduce a new context modification identifier, RemoveEmptyStavesAll, to complement RemoveEmptyStaves. It sets both the remove-empty _and_ remove-first properties of VerticalAxisGroup to ##t.

Patch Set 1 #

Patch Set 2 : Rename new command according to vote #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -37 lines) Patch
M Documentation/changes.tely View 1 1 chunk +6 lines, -1 line 0 comments Download
M Documentation/notation/staff.itely View 1 7 chunks +21 lines, -36 lines 0 comments Download
M ly/context-mods-init.ly View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 8
simon.albrecht
8 years, 2 months ago (2016-01-14 15:11:14 UTC) #1
dak
The name is rather clumsy (and it does not help that the issue report talks ...
8 years, 2 months ago (2016-01-14 15:20:13 UTC) #2
simon.albrecht
On 14.01.2016 16:20, dak@gnu.org wrote: > The name is rather clumsy (and it does not ...
8 years, 2 months ago (2016-01-14 15:34:36 UTC) #3
t.daniels_treda.co.uk
Simon Albrecht wrote Thursday, January 14, 2016 3:34 PM > On 14.01.2016 16:20, dak@gnu.org wrote: ...
8 years, 2 months ago (2016-01-14 15:50:09 UTC) #4
dak
"Trevor Daniels" <t.daniels@treda.co.uk> writes: > Simon Albrecht wrote Thursday, January 14, 2016 3:34 PM > ...
8 years, 2 months ago (2016-01-14 16:16:39 UTC) #5
Jean-Charles
On 2016/01/14 16:16:39, dak wrote: > > \RemoveEmptyStavesFirst would be used in context definitions to ...
8 years, 2 months ago (2016-01-14 17:50:55 UTC) #6
simon.albrecht
Rename new command according to vote
8 years, 2 months ago (2016-01-15 00:27:00 UTC) #7
simon.albrecht
8 years, 2 months ago (2016-01-15 00:30:25 UTC) #8
Renamed the new command according to the vote.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b