Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1531)

Issue 28159: Nickname validation and removal of duplicates (issue99). (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
15 years ago by Andi
Modified:
11 years, 8 months ago
Reviewers:
JohnA, GvR
Visibility:
Public.

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+169 lines, -45 lines) Patch
M app.yaml View 1 chunk +4 lines, -0 lines 1 comment Download
M codereview/feeds.py View 1 chunk +12 lines, -5 lines 0 comments Download
M codereview/models.py View 3 chunks +22 lines, -14 lines 0 comments Download
M codereview/views.py View 4 chunks +38 lines, -26 lines 1 comment Download
A tools/appengine_console.py View 1 chunk +31 lines, -0 lines 0 comments Download
A update_accounts.py View 1 chunk +62 lines, -0 lines 0 comments Download

Messages

Total messages: 5
Andi Albrecht
* Changed the way how default nicknames for new users are computed. It now uses ...
15 years ago (2009-03-31 19:18:46 UTC) #1
JohnA
The approach looks good to me (wasn't aware of the new remote api). One question: ...
14 years, 11 months ago (2009-04-07 20:21:10 UTC) #2
Andi Albrecht
On 2009/04/07 20:21:10, JohnA wrote: > The approach looks good to me (wasn't aware of ...
14 years, 11 months ago (2009-04-08 07:18:38 UTC) #3
Andi Albrecht
On 2009/04/08 07:18:38, Andi Albrecht wrote: > On 2009/04/07 20:21:10, JohnA wrote: > > The ...
14 years, 11 months ago (2009-04-16 11:21:00 UTC) #4
Andi Albrecht
14 years, 11 months ago (2009-04-16 11:28:15 UTC) #5
http://codereview.appspot.com/28159/diff/1/5
File codereview/views.py (right):

http://codereview.appspot.com/28159/diff/1/5#newcode1141
Line 1141: db_email = db.Email(accounts[0].user.email().lower())
This bug was fixed in r411.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld f62528b