Issue 28147: review of Python issue 5236

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 28147: review of Python issue 5236 (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
15 years, 1 month ago by brett.cannon

Modified:
14 years, 9 months ago

Reviewers:

CC:
tleeuwenburg

Base URL:
http://svn.python.org/view/*checkout*/python/trunk/

Visibility:
Public.

Patch Set 1 #

Total comments: 3

Downloaded from: http://bugs.python.org/file13355/strptime_patch_v2.txt

Created: 15 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
		Lib/_strptime.py	View		1 chunk	+6 lines, -0 lines	1 comment	Download
		Lib/test/test_time.py	View		1 chunk	+4 lines, -0 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

brett.cannon

15 years, 1 month ago (2009-03-30 21:10:38 UTC) #2

Changes are all minor and I have made them in my copy. Once I make sure my
changes work for the docs I will check it in.

http://codereview.appspot.com/28147/diff/1/3
File Lib/_strptime.py (right):

http://codereview.appspot.com/28147/diff/1/3#newcode301
Line 301: 
Why isn't the ASCII flag to re.compile not used with this in place?

http://codereview.appspot.com/28147/diff/1/2
File Lib/test/test_time.py (right):

http://codereview.appspot.com/28147/diff/1/2#newcode119
Line 119: def test_srptime_bytesarg(self):
Misspell and no comment on what is being tested.

http://codereview.appspot.com/28147/diff/1/2#newcode121
Line 121: 
Extraneous newline.

Expand All Messages | Collapse All Messages