Issue 280940043: Fix documentation of \once \partcombine*

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 280940043: Fix documentation of \once \partcombine*

Can't Edit
Can't Publish+Mail
Start Review

Created:
8 years, 4 months ago by dak

Modified:
8 years, 4 months ago

Reviewers:
Trevor Daniels

CC:
lilypond-devel_gnu.org

Visibility:
Public.

More Reviews

Description

Fix documentation of \once \partcombine* This is an oversight stemming from issue 4131.

Patch Set 1 #

Total comments: 2

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -14 lines)			Patch
	M	Documentation/notation/simultaneous.itely	View		1 chunk	+13 lines, -14 lines	2 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Trevor Daniels

LGTM, apart from a pre-existing typo. https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simultaneous.itely File Documentation/notation/simultaneous.itely (right): https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simultaneous.itely#newcode1030 Documentation/notation/simultaneous.itely:1030: case the @code{\partcombine} ...

8 years, 4 months ago (2015-12-13 12:04:02 UTC) #1

dak

8 years, 4 months ago (2015-12-13 15:01:24 UTC) #2

https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simult...
File Documentation/notation/simultaneous.itely (right):

https://codereview.appspot.com/280940043/diff/1/Documentation/notation/simult...
Documentation/notation/simultaneous.itely:1030: case the @code{\partcombine}
function can be overriden with one of the
On 2015/12/13 12:04:02, Trevor Daniels wrote:
> May as well correct this while you are there:
> "overridden"

Will fix but not load up a new patch for review for this alone.

Expand All Messages | Collapse All Messages