Issue 28078: Make ServletTestFixture abstract to avoid misuse

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Can't Edit
Can't Publish+Mail
Start Review

Created:
16 years, 6 months ago by cnwan

Modified:
16 years, 6 months ago

Reviewers:
louiscryan

CC:
shindig.remailer_gmail.com

Base URL:
http://svn.apache.org/repos/asf/incubator/shindig/trunk/

Visibility:
Public.

ServletTestFixture is supposed to be inherited by test classes and should not be directly instantiable. Make it abstract and fix one misuse.

Created: 16 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -6 lines)			Patch
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/OAuthCallbackServletTest.java	View		1 chunk	+3 lines, -5 lines	0 comments	Download
		java/gadgets/src/test/java/org/apache/shindig/gadgets/servlet/ServletTestFixture.java	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4

louiscryan

16 years, 6 months ago (2009-03-23 16:33:45 UTC) #4

Looks good. As a non-committer its good practice to attach the patch to a JIRA
issue

Thanks!